From owner-cvs-all  Fri Jun 15 20:26:26 2001
Delivered-To: cvs-all@freebsd.org
Received: from phaidor.thuvia.org (thuvia.demon.co.uk [193.237.34.248])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7E27237B409; Fri, 15 Jun 2001 20:26:05 -0700 (PDT)
	(envelope-from mark@thuvia.demon.co.uk)
Received: from dotar-sojat.thuvia.org (dotar-sojat.thuvia.org [10.0.0.4])
	by phaidor.thuvia.org (8.11.3/8.11.3) with ESMTP id f5G3QSS02356;
	Sat, 16 Jun 2001 04:26:28 +0100 (BST)
	(envelope-from mark@dotar-sojat.thuvia.org)
Received: (from mark@localhost)
	by dotar-sojat.thuvia.org (8.11.4/8.11.4) id f5G3QAH00242;
	Sat, 16 Jun 2001 04:26:10 +0100 (BST)
	(envelope-from mark)
Date: Sat, 16 Jun 2001 04:26:10 +0100 (BST)
From: Mark Valentine <mark@thuvia.demon.co.uk>
Message-Id: <200106160326.f5G3QAH00242@dotar-sojat.thuvia.org>
In-Reply-To: Garance A Drosihn's message of Jun 15, 10:43pm
X-Mailer: Mail User's Shell (7.2.6 beta(5) 10/07/98)
To: gad@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> From: drosih@rpi.edu (Garance A Drosihn)
> Date: Fri 15 Jun, 2001
> Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c

> In the middle of writing the commit-log, I remembered that I
> wanted to cross-check one more thing.  So, I deleted all the
> non-CVS (comment) lines in the window, and exited.  It seemed
> to me that that USED to cause the commit to stop and ask you
> if you wanted to abort the commit.

CVS doesn't like you deleting the leading blank line it starts you out
with.

I always thought this was just a dumb comparison of the file before and
after editing, and it's annoyed me for years, but I just looked at the
code, which tries to be a bit more clever but gets this (common) case
wrong.

I've submitted simple fixes to bug-cvs and via send-pr to freebsd-bugs:
see PR gnu/28189.

		Cheers,

		Mark.

-- 
Mark Valentine, Thuvia Labs <mark@thuvia.co.uk>       <http://www.thuvia.co.uk>
"Tigers will do ANYTHING for a tuna fish sandwich."       Mark Valentine uses
"We're kind of stupid that way."   *munch* *munch*        and endorses FreeBSD
  -- <http://www.calvinandhobbes.com>                  <http://www.freebsd.org>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message