From owner-svn-src-head@freebsd.org Sat Jul 23 00:26:00 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 434F2BA2509; Sat, 23 Jul 2016 00:26:00 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id AEC50171C; Sat, 23 Jul 2016 00:25:59 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c110-21-100-149.carlnfd1.nsw.optusnet.com.au [110.21.100.149]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id D12583C554B; Sat, 23 Jul 2016 10:25:48 +1000 (AEST) Date: Sat, 23 Jul 2016 10:25:48 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ngie Cooper cc: Bruce Evans , John Baldwin , Ruslan Bukin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r303188 - head/share/mk In-Reply-To: Message-ID: <20160723100100.K1644@besplex.bde.org> References: <201607221500.u6MF0c3S037470@repo.freebsd.org> <1980140.IgFQbb5iVz@ralph.baldwin.cx> <20160723073428.K1265@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=OtmysHLt c=1 sm=1 tr=0 a=XDAe9YG+7EcdVXYrgT+/UQ==:117 a=XDAe9YG+7EcdVXYrgT+/UQ==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=khO1dhh0rlZb77YnPP0A:9 a=CjuIK1q_8ugA:10 a=Oa0T6EYmKFNB-xRHvYM1:22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2016 00:26:00 -0000 On Fri, 22 Jul 2016, Ngie Cooper wrote: > On Fri, Jul 22, 2016 at 2:57 PM, Bruce Evans wrote: > ... >>>> +# GCC 6.1.0 >>>> +.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 60100 >>>> +CWARNFLAGS+= -Wno-error=unused-const-variable= >>>> -Wno-error=nonnull-compare -Wno-error=shift-negative-value >>>> -Wno-error=misleading-indentation -Wno-error=tautological-compare >>>> +.endif >>> >>> >>> Extra trailing = in the first one as well? >> >> I don't see one. I see only unreadably long lines containing unreadably >> unordered flags. Perhaps your mail client mangled the line splitting, >> but the above quite displays OK in mutt and vi here (except mutt makes >> the line wrapping especially ugly by highlighting it). > > Look for "-Wno-error=unused-const-variable=". It is not trailing :-). It is only trailing in the above quote and apparently in the mail as seen by jhb because some mail programs mangle the formatting worse than others. In the above quote as seen by me in EDITOR=vi, the long line is split and each part is quoted. But in the previous quote, the line wasn't split. Since it was unreadable by me, I used the editor search function to check if it had a trailing '=' using a regexp, and none was found. The corresponding line for gcc 5.2.0 in bsd.sys.mk has the same quality. The '='s in the correct part of the syntax are not very good either. I think they break our policy that all warnings are fatal unless NO_WERROR is set. Already clang allows too many things to compile without even warnings. I think this allows them to compile with gcc's stricter warnings, but only with newer gcc's. NO_WERROR is too global, but is at least easy to understand. Bruce