From owner-freebsd-ports@freebsd.org Thu May 17 22:43:31 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FD30EE27AA for ; Thu, 17 May 2018 22:43:31 +0000 (UTC) (envelope-from john@saltant.com) Received: from twaddle.saltant.net (twaddle.saltant.net [IPv6:2001:470:8d6f:1001::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C53557A263; Thu, 17 May 2018 22:43:30 +0000 (UTC) (envelope-from john@saltant.com) Received: from statler.priv.n.saltant.net (unknown [IPv6:2001:470:8d6f:0:e846:d746:756a:3b9e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by twaddle.saltant.net (Postfix) with ESMTPSA id C0CAD111E5; Thu, 17 May 2018 18:43:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=saltant.com; s=twaddle; t=1526597009; bh=INzVj2LrmCD6ZTLyoJ5e2pbwxSmxzZtl0kTjKOdp7Tc=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=hW1ZvzBO4T4XMgXRho5ftLDAm6FwnUnSbKnsep8sxW0UPVZPcNphjDoNt4KOXGRuS VyZMAlQVv8mYNR4j/ctUudxaKMzJ8lzSarHFmUaoVRvr+sm6RqTWMvJ61W26+lTQam jjoQyOG1MHh7c4O0ICZtl+wEjk+lkQ85OZRTnnt/Eq8h07LxSGgfuQgAlOXXinelQ4 suycAMPLKw8QoRuI9SCYylXUxeTjsiX4lIyHPJd8fDg+SIYz9MmDUO+tbwrXbhccvv n91er92NgzZhJbWo3Lc6tdEb38oHh9kgf+x3lq4vRKmXe0VF/6kcRz7Yt8OSDtWyyv bLrokd+3IxnHg== Subject: Re: Practice of "Sponsored by" in commit messages To: Maxim Sobolev Cc: FreeBSD Ports References: From: "John W. O'Brien" Autocrypt: addr=john@saltant.com; prefer-encrypt=mutual; keydata= xsFNBFpcMG0BEACeAEQ0ZTUEH+6B8XIBid2H8g1yY+niHxVphqz8JwnQtYX+bS+Kl3vr783F HH81DEbfPtYgHY53NF9FjSzCyj13lXVnEGQOdxXzZVKsN1nyuXCN2hDOFH7Yc5yQ8h85T4Hv sqPIGIXOztu4MX14iUAcTgLhfibNQBeKDeNI+BBeaE9lPuNVeiM+xsI4JYcjmDbjFzAHRpBo ull0koUFh6RZAKE7u17yLej1pTIQQVjQpWdK37BAq4hdkLwjGDY8mDGo3ZwGdNibxIAxv/wi KU6u2DfUg8+kLHIhOqk/+kFQ/uK5YA1azsyD5eIbNAs4W7LglA6SkiGBglTwkP0VCrkPdD14 6sx3U7uFgexDWbVuhLIkcPQ0SRmnjgUKHgk7px/jMvAPKSKoL0JQNdP/+pnO9CDLGmoHx9gE 5kVr5dQK8c/WauEfimAdE9qLuN6vb0Iei73q3e3OOHAUusR5wC5SwXt4iilbaK4r04NKXyfb SB3+qWST07F9cmMscfEStSBhpez3awB+1jz8gr40tkEGsFZGvD2KKAgZdKpoxv6IrZepclWz HpqHF01SRFORYMsd1d83XlEu/S1/Z9YJ87RoCdZuYCkjnoRPtpTi9d+JD/u3ZiQFwLUz/Ne3 VqiGKvY66EGcO3tvANMg6GWD9sqlnBDp9Lls0ChEY3dgDYd6DQARAQABzSJKb2huIFcuIE8n QnJpZW4gPGpvaG5Ac2FsdGFudC5jb20+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAFiEENPkbBr3zmPAVSH2HM8TWS4ldvzsFAlpcMTMFCQX2qcYACgkQM8TWS4ldvztT xQ//eHb1mgd40Z0fN2GnJti6/9uJ771IO6slFQ02GZcXZI+FIQo8Yd1dHe0e0Codu78qvJNr ggUtqdxH6SVp7K1AWHeLH5S0PF6iG5B+YUux080wEv/Mr8PPMgAD8gS3wiPDDgB/kUXO52bn DC3Fc0dUrFE/JAOByVEEDL5nLF6SQNpAtIUnaAIIuhKxi0d40LMcLUwuJ6jExynw8Iu7OVtu Y1PRAH5ESt6wYZq8ro8ukh4rMOxiWtT1yNEgHgnq3N4jKErVo87YJijHSSj80IKxUiKb/T6K tGTEBTKiSUV3OFj0ZoPxcbUmhIg2sBCNHaUCiI0KabqN1NyK2glKtcK6NpWy3JIHvtr3+VL1 /tvQTwlVUIacmsuxkGzm5vJPs/i2RtwsJXEXPmIRNgJ1EwZgpg5VqqEUDlmSyRLb48QcDrdv utKLA1MKLib1fD+0XmxZTbCMlFMlvJjAoBlVq60mvB/Jnv1TTnZ2eN6DKMWoxHKmPICh5F1q esmT/aJRIUoCiAgcChi4Ol4XmW3dM7ypjKCGHzyr6emCky5pjqSQZyFzg0RN5UjUQBISAGmJ E8hCFZIy7tf8meqIDbtkONh+JShN6u3t02JrnzSOQjZCh5WQW9Pnu7unJlIsYB10aZ6rvuAK YjghT8QLG8QVgJj/U9oeVG1Ag60fmLZdOFjRGmnOwU0EWlwwbQEQANebvidw1D5SKSmG3Ut8 p9vngBi5HjYe4FSYcfz0NgYa893RiScQ6yjOwuEf/fEoBgvpVnhcbu0JsaYvDNNzFGzPQcj0 CFhkr5s7REWNLGmmFCxCaGieTxIQdYsLxwn72mops8bsrL0a++8NDE+l7X4K3EUyp9GP7pIq 4l9jeIJ/RnX3yySRlXxcM3P+DV9ltXsnQ9pC/qEVVyK18C1zoiskhxmAY9cv9TJOaANHtA7R 7+hM5TyppIz7kqiwiCf6XfVFqKH0I0srdamb0KTnAZpmyx7iNKYl60PdIfEwkwck8fcGwOSA lwE9CLkHLwKMjx/gF3xRag5xjOdP/Out0cQ/pXv8DWnKblWbiGZheB4xUqhOT9Cj/8u/tKtC 51C9wID26hsrhtSAMJPUwQoo/SwLNEd1JpkqUP1njOdlV8FmM1EozHLPSvwlTm6oWwubkkY6 QkUHqXuO+2VdNhyDfx23fQhd0UPhQ0ceDRnjaSB9ycWqpktBP5iNQajYbx5Ktt8fC2Y+Ztjo u1KY7wJSUzqh7uZgR1TqIOVZp7bdPLBGHW5eNEf0Awq17utGe6d9i4hPmeNqELUz71hjmABm bIQJ+VgqYcQ0T/PrjwhzHv5g3jn67/ftW91nlTNpbhwm8suIdPA1hF6vgnZ3B4+JsevnevLG yU6YCb0OOKleP6pZABEBAAHCwXwEGAEIACYCGwwWIQQ0+RsGvfOY8BVIfYczxNZLiV2/OwUC WlwxTQUJBBV2YAAKCRAzxNZLiV2/O2PnD/wMKz/rzYbf0SaTvgae4jqryrcWRta56dcnVe7W KPuUu4Q/WBGhXKeCfPrlr399bILxZGw5TXuGMjS8gEoMd81PEMcWaMpgg3F569Cxd9GN6AZd LXXrZa0aM7dvZkz98ymILEnqHMpF74sLvZY2PrsOwo2gKXNqhtCJ2ph8OUKhG+NHvAomjMu9 lPQMkXJ4HRV0OljawqAe4y+IFu2K4abWwZw1mdniTCb5al8V2umzf26QL0DgeFp3banlfjYW Dn5cRuDBQqIoR/6cQaKdFKTJYiTVK3p3WRWiJQniYi39S8CR646w+zVi7ax1shSB0r0lxIFo CZu285HcMd7HsHH+T2ZI45ilayUoyoZvxPPlwhiRzyYZ6qqAAXKDihhda7uNApUqLwoSn5FW njmx6KdlVPF9ycCdf+in5k6nVlHWG15ogF/Y96K+/Q1Iuod9rzWqT4bz9a5olY8r++QE3V1b H3z803wXEUAJg+WGTkYXFNw7w6RhSSEhBRzupDoCROSkRhe3vQGy5FLG+BMV9n9nevhj5sBx CM1BbNBdB5H/2RcXh0wSb6zjewgs3UAbBvCQOdMAMo8XpYM5SLBqtaY7oalBElTxtFnwSNJm hMbahYE/wHbkmMqalrzGyQxbSUdrmE64CIX8xmv47fnjRoTZMzKim/02MRH+Ss1M+rLzpw== Organization: Saltant Solutions Message-ID: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> Date: Thu, 17 May 2018 18:43:25 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XzZylNZFp0InfREf4gwAdQEerniP8HJgr" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 22:43:31 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XzZylNZFp0InfREf4gwAdQEerniP8HJgr Content-Type: multipart/mixed; boundary="52Q63lRXW8gZSO3YM6fGEotGPUesvWJF4"; protected-headers="v1" From: "John W. O'Brien" To: Maxim Sobolev Cc: FreeBSD Ports Message-ID: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> Subject: Re: Practice of "Sponsored by" in commit messages References: In-Reply-To: --52Q63lRXW8gZSO3YM6fGEotGPUesvWJF4 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018/05/14 20:14, Maxim Sobolev wrote: > What's wrong with a current practice. Why is it of any concern to you, > John? Just curious that is not very clear from your message. It is like= > someone trying to moderate what people in general or some group in > particular (e.g. freebsd committers) are allowed to put on their > t-shirts just because you find it offensive or inappropriate. I don't find crediting sponsors offensive nor inappropriate. Quite the contrary. What I find problematic is when multiple people do work, not all with sponsorship or the same sponsorship, and only one person's sponsor is mentioned in a way that seems to imply that all the work was sponsored. What I'm proposing is not to end or ban the practice, but to improve and refine it so that sponsors are credited for what they sponsor and not for what they don't sponsor. Is that clearer? > On Mon, May 14, 2018, 4:40 PM John W. O'Brien > wrote: >=20 > Hello FreeBSD Ports, >=20 > The Committer's Guide section on Commit Log Messages [0], doesn't c= over > the use of the "Sponsored by" key word. As a non-committer contribu= tor, > it only recently occurred to me to wonder what work that credit is > intended to represent, and whether some light definition would be > helpful to reduce ambiguity. >=20 > When a committer credits a sponsor of theirs, from which the contri= butor > received no sponsorship, the portrayal feels a little awkward. Does= this > strike the list as a problem, and if so, how ought it be solved? >=20 > To make this concrete, allow me to illustrate the situation. >=20 > Alice, working on her own time, prepares and contributes a patch. B= ob, > who works for Acme Corp, reviews and commits the patch on company t= ime. > The commit message includes "Sponsored by: Acme Corp". Alice eagerl= y > awaits her check from Acme Corp. Should the commit message have rea= d > "Sponsored by: Acme Corp (Bob)"? >=20 > This could be extensible to multiple sponsorships. If, instead, Ali= ce > prepares the patch having received a grant to do so from Best Sys D= ev, > the commit message could state "Sponsored by: Acme Corp (Bob), Best= Sys > Dev (Alice)". >=20 > [0] > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-gui= de/article.html#commit-log-message >=20 > PS: I realize that this issue transcends ports, but it's not clear = where > I should send this instead, and this list seems like it would have = a > reasonably high concentration of people with a stake in the discuss= ion. --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --52Q63lRXW8gZSO3YM6fGEotGPUesvWJF4-- --XzZylNZFp0InfREf4gwAdQEerniP8HJgr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr+BY0ACgkQWPtK56pP /m4s3gf8CH5kAmx6Dy/eBgjZ37edsXFRoAfWe19dbuPnq1fU2V9dWrkW8uF7lhTJ tkRIXUjG6DgkJY9nOxDcBbOrp8noJh8eglERekAwzdfI20Y/QqqHj5MUYMwTRxfs O5BQGCHf1d3pk5JqrWJ7i9IamaPcRrGl3kwjPJpYhhiM0ZesDe7LbhiEBLViq+9P PJtQvBC/vpSxOprbsOO1gWEkiE5/iHRFxoSsAGM0tL5QsXbr347vi7oP/3dOzJ3W 56FA7PVY7d6I0K40Jl2EPUFNV7cGGHRnsFu5mB7EGqkniY/Y61zqpeEfVNEwOOul EKerY+HNSGigv0C00ileaFfKhi3YNg== =Syb7 -----END PGP SIGNATURE----- --XzZylNZFp0InfREf4gwAdQEerniP8HJgr--