From owner-freebsd-hackers@FreeBSD.ORG Tue May 20 19:35:32 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 26895106566B for ; Tue, 20 May 2008 19:35:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 100CC8FC25 for ; Tue, 20 May 2008 19:35:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (server.baldwin.cx [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id B36A01A4D7E; Tue, 20 May 2008 12:35:31 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m4KJZLXp053053; Tue, 20 May 2008 15:35:23 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andriy Gapon Date: Tue, 20 May 2008 15:34:41 -0400 User-Agent: KMail/1.9.7 References: <1210616585.00069210.1210605002@10.7.7.3> <200805201124.23850.jhb@freebsd.org> <48331F69.3070205@icyb.net.ua> In-Reply-To: <48331F69.3070205@icyb.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805201534.42201.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 20 May 2008 15:35:23 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7182/Tue May 20 12:09:32 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-hackers@freebsd.org, RW Subject: Re: i386 cpu_reset_real: code/comment mismatch X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2008 19:35:32 -0000 On Tuesday 20 May 2008 02:58:49 pm Andriy Gapon wrote: > on 20/05/2008 18:24 John Baldwin said the following: > > On Tuesday 20 May 2008 09:37:54 am Andriy Gapon wrote: > >> BTW, I understand that there is a difference between hard and soft reset > >> in terms of hardware signals being asserted, but I don't quite > >> understand general consequences. I.e. what is a practical difference > >> between hard and soft reset? > > > > I've no idea. It may be that we should just always do a hard reset as that is > > in effect what both Solaris and Linux do. I'll probably just change it to do > > that. > > But I think it is already how the code works (maybe with extra port > write that couldn't hurt anything). Right, I'll probably just update the comment and remove the '0x2' write. -- John Baldwin