From owner-svn-src-stable-10@freebsd.org Wed Jun 1 17:45:01 2016 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6ECC5B61340; Wed, 1 Jun 2016 17:45:01 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3BBBD11F1; Wed, 1 Jun 2016 17:45:01 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u51Hj0FN060366; Wed, 1 Jun 2016 17:45:00 GMT (envelope-from truckman@FreeBSD.org) Received: (from truckman@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u51Hj0Ai060365; Wed, 1 Jun 2016 17:45:00 GMT (envelope-from truckman@FreeBSD.org) Message-Id: <201606011745.u51Hj0Ai060365@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: truckman set sender to truckman@FreeBSD.org using -f From: Don Lewis Date: Wed, 1 Jun 2016 17:45:00 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: svn commit: r301154 - stable/10/lib/libfetch X-SVN-Group: stable-10 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 17:45:01 -0000 Author: truckman Date: Wed Jun 1 17:45:00 2016 New Revision: 301154 URL: https://svnweb.freebsd.org/changeset/base/301154 Log: MFC r300666 Call closedir() before returning from fetchListFile() to avoid a leak. Reported by: Coverity CID: 1016697 Modified: stable/10/lib/libfetch/file.c Directory Properties: stable/10/ (props changed) Modified: stable/10/lib/libfetch/file.c ============================================================================== --- stable/10/lib/libfetch/file.c Wed Jun 1 17:43:04 2016 (r301153) +++ stable/10/lib/libfetch/file.c Wed Jun 1 17:45:00 2016 (r301154) @@ -149,5 +149,6 @@ fetchListFile(struct url *u, const char fetch_add_entry(&ue, &size, &len, de->d_name, &us); } + closedir(dir); return (ue); }