From owner-freebsd-current  Mon Sep  3  4:37: 8 2001
Delivered-To: freebsd-current@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id AEB5337B409; Mon,  3 Sep 2001 04:37:04 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA23414;
	Mon, 3 Sep 2001 21:37:01 +1000
Date: Mon, 3 Sep 2001 21:36:46 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@alphplex.bde.org>
To: Jordan Hubbard <jkh@FreeBSD.ORG>
Cc: <current@FreeBSD.ORG>
Subject: Re: Build problem in -current
In-Reply-To: <20010902115310W.jkh@freebsd.org>
Message-ID: <20010903210756.V7393-100000@alphplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Sun, 2 Sep 2001, Jordan Hubbard wrote:

> cd /usr/src/usr.bin/xinstall; make _EXTRADEPEND
> echo xinstall: /usr/obj/usr/src/i386/usr/lib/libc.a  >> .depend
> cc -O -pipe    -I/usr/obj/usr/src/i386/usr/include  -c /usr/src/usr.bin/xinstall
> /xinstall.c
> cc -O -pipe    -I/usr/obj/usr/src/i386/usr/include   -static -o xinstall xinstal
> l.o
> xinstall.o: In function `main':
> xinstall.o(.text+0x83): undefined reference to `strtofflags'
> *** Error code 1
>
> This is from a relatively old -current coming up to a new (today's)
> -current.  I suspect somebody added a call for install yet forgot to
> alter the bootstrap tools target accordingly (or did but in the wrong
> place).  Thanks.

Index: Makefile
===================================================================
RCS file: /home/ncvs/src/usr.bin/xinstall/Makefile,v
retrieving revision 1.15
diff -u -2 -r1.15 Makefile
--- Makefile	2 Apr 2001 11:54:59 -0000	1.15
+++ Makefile	3 Sep 2001 11:18:33 -0000
@@ -2,6 +2,9 @@
 # $FreeBSD: src/usr.bin/xinstall/Makefile,v 1.15 2001/04/02 11:54:59 ru Exp $

+.PATH: ${.CURDIR}/../../lib/libc/gen
+
 PROG=		xinstall
 PROGNAME=	install
+SRCS=		strtofflags.c xinstall.c
 MAN=		install.1

Unfixed bugs: this will have to be fixed better before turning on WARNS.
strtofflags() won't be declared in the host includes if the host libraries
don't have it.  Similarly in mtree (where I obtained this fix from) and
in any other tools that use strtofflags().  All these bugs were missing in
the old versions that used ls's version of strtofflags.

Nearby bugs: mtree/Makefile uses !defined(WORLD) to avoid depending on
the host having libmd, but someone removed the definition of WORLD from
src/Makefile.inc1.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message