From owner-svn-src-all@freebsd.org  Wed Dec 21 15:45:24 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B13CFC8A68D;
 Wed, 21 Dec 2016 15:45:24 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 757DA1BD3;
 Wed, 21 Dec 2016 15:45:24 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id uBLFjNMj024758;
 Wed, 21 Dec 2016 15:45:23 GMT (envelope-from emaste@FreeBSD.org)
Received: (from emaste@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id uBLFjNgp024757;
 Wed, 21 Dec 2016 15:45:23 GMT (envelope-from emaste@FreeBSD.org)
Message-Id: <201612211545.uBLFjNgp024757@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: emaste set sender to
 emaste@FreeBSD.org using -f
From: Ed Maste <emaste@FreeBSD.org>
Date: Wed, 21 Dec 2016 15:45:23 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r310371 - head/sys/dev/bhnd/tools
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2016 15:45:24 -0000

Author: emaste
Date: Wed Dec 21 15:45:23 2016
New Revision: 310371
URL: https://svnweb.freebsd.org/changeset/base/310371

Log:
  bhnd: remove srand() to ensure deterministic output
  
  r310342 fixed non-deterministic nvram_map_gen.awk output and thus a non-
  reproducible bhnd(4) build by using a unique sort key.
  
  Go one step further and also remove the srand() call. There's no reason
  we want non-deterministic behaviour from this script.
  
  PR:		215422
  Reported by:	gjb (non-reproducibility of bhnd)
  Reported by:	lidl (srand as the cause)
  Reviewed by:	landonf
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D8857

Modified:
  head/sys/dev/bhnd/tools/nvram_map_gen.awk

Modified: head/sys/dev/bhnd/tools/nvram_map_gen.awk
==============================================================================
--- head/sys/dev/bhnd/tools/nvram_map_gen.awk	Wed Dec 21 15:40:16 2016	(r310370)
+++ head/sys/dev/bhnd/tools/nvram_map_gen.awk	Wed Dec 21 15:45:23 2016	(r310371)
@@ -52,9 +52,6 @@ function main(_i) {
 		AWK_REQ_HEX_PARSING=1
 	}
 
-	# Seed rand()
-	srand()
-
 	# Output type
 	OUT_T = null
 	OUT_T_HEADER = "HEADER"