From owner-svn-src-projects@FreeBSD.ORG Mon Mar 4 21:21:09 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 00491FE7; Mon, 4 Mar 2013 21:21:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id CECB915F5; Mon, 4 Mar 2013 21:21:08 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C4F92B926; Mon, 4 Mar 2013 16:21:07 -0500 (EST) From: John Baldwin To: attilio@freebsd.org Subject: Re: svn commit: r247710 - projects/calloutng/sys/kern Date: Mon, 4 Mar 2013 16:20:51 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201303031339.r23DdsBU047737@svn.freebsd.org> <201303041521.06557.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201303041620.52100.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 04 Mar 2013 16:21:07 -0500 (EST) Cc: Davide Italiano , svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2013 21:21:09 -0000 On Monday, March 04, 2013 3:41:05 pm Attilio Rao wrote: > On Mon, Mar 4, 2013 at 9:21 PM, John Baldwin wrote: > > On Monday, March 04, 2013 3:17:30 pm Davide Italiano wrote: > >> On Mon, Mar 4, 2013 at 4:40 PM, John Baldwin wrote: > >> > On Sunday, March 03, 2013 8:39:54 am Davide Italiano wrote: > >> >> Author: davide > >> >> Date: Sun Mar 3 13:39:54 2013 > >> >> New Revision: 247710 > >> >> URL: http://svnweb.freebsd.org/changeset/base/247710 > >> >> > >> >> Log: > >> >> - Use TRUE/FALSE in lieu of 0/1 for boolean_t variables. > >> > > >> > We have stdbool in the kernel. Why not use that instead of the Machish > >> > boolean_t? > >> > > >> > -- > >> > John Baldwin > >> > >> It was originally int, and a couple of days ago Attilio suggested to > >> move to 'boolean_t'. > >> Honestly, I didn't argue due to the relative little relevance of the > >> change, but actually I find the type change more explicative. > >> I have no strong objections to change it again (in particular because > >> I think you're suggesting to use bool to be C99 compliant, feel free > >> to correct me if I'm wrong). > >> > >> While here. After closer looking I realized boolean_t is widely used > >> in the kernel (e.g. sys/kern/). Is this just a common error or is > >> there something I'm missing? > > > > No, it's just older and bool is C99 as you noticed. I had thought that > > boolean_t was largely regulated to code from Mach (i.e. sys/vm) and that > > we should use bool for new code. > > Actually boolean_t is much more widespread in our kernel than the C99 > variant. Moreover style(9) doesn't advertise it either, neither the > necessity to conform to library defined C99 features (even if present > in the C99 standard, _Bool is still defined in stdbool.h which is an > header not present in our kernel). Err, I thought that mdf@ had proposed importing stdbool.h into our kernel already? Ah, yes, the requisite bits are in , so 'bool' works fine. I think for new code we should prefer C99's bool to boolean_t. -- John Baldwin