From owner-cvs-all  Mon Jan 14  0:48:41 2002
Delivered-To: cvs-all@freebsd.org
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8A6A937B417; Mon, 14 Jan 2002 00:48:33 -0800 (PST)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 5C2C010DE00; Mon, 14 Jan 2002 00:48:33 -0800 (PST)
Date: Mon, 14 Jan 2002 00:48:33 -0800
From: Alfred Perlstein <alfred@FreeBSD.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/contrib/ipfilter/ipsend sock.c
Message-ID: <20020114004833.G7984@elvis.mu.org>
References: <200201140410.g0E4Aa763865@freefall.freebsd.org> <20020114161223.E4436-100000@gamplex.bde.org> <20020114103437.A85961@sunbay.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20020114103437.A85961@sunbay.com>; from ru@FreeBSD.org on Mon, Jan 14, 2002 at 10:34:37AM +0200
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

* Ruslan Ermilov <ru@FreeBSD.org> [020114 00:35] wrote:
> On Mon, Jan 14, 2002 at 04:20:23PM +1100, Bruce Evans wrote:
> > On Sun, 13 Jan 2002, Alfred Perlstein wrote:
> > 
> > > alfred      2002/01/13 20:10:36 PST
> > >
> > >   Modified files:
> > >     contrib/ipfilter/ipsend sock.c
> > >   Log:
> > >   add queue.h, now needed for file.h
> > >
> > >   Revision  Changes    Path
> > >   1.9       +4 -1      src/contrib/ipfilter/ipsend/sock.c
> > 
> > This is file.h's responsibility.  file.h already includes queue.h, so
> > the problem must be elsewhere.  Anyway, it is a bug if changes of
> > kernel implementation details affect prerequisites in applications.
> > 
> Moving <sys/queue.h> from after <sys/_mutex.h> to before <sys/_lock.h>
> in file.h should fix the problem.

*doh*, Now I'm a bit flustered, shall I go ahead and backout the
queue.h additions to userland and make this suggested change?

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message