From owner-cvs-all Thu Oct 10 8:46:55 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B5CA37B401; Thu, 10 Oct 2002 08:46:52 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0993A43EB2; Thu, 10 Oct 2002 08:46:52 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 1670C2A88D; Thu, 10 Oct 2002 08:46:48 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Doug Rabson Cc: Alfred Perlstein , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ia64/ia32 ia32_misc.c syscalls.master In-Reply-To: <20021010155642.K70762-100000@herring.nlsystems.com> Date: Thu, 10 Oct 2002 08:46:48 -0700 From: Peter Wemm Message-Id: <20021010154648.1670C2A88D@canning.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Doug Rabson wrote: > On Wed, 9 Oct 2002, Peter Wemm wrote: > > > Alfred Perlstein wrote: > > > * Alfred Perlstein [021009 15:28] wrote: > > > > * Peter Wemm [021009 15:27] wrote: > > > > > peter 2002/10/09 15:27:24 PDT > > > > > > > > > > Modified files: > > > > > sys/ia64/ia32 ia32_misc.c syscalls.master > > > > > Log: > > > > > Try and deal with the #ifdef COMPAT_FREEBSD4 sendfile stuff. This woul > > d > > > > > have been a lot easier if do_sendfile() was usable externally. > > > > > > > > I don't object to it being made non-static. > > > > > > However using SCARG is depricated according to bde, shouldn't you > > > just use struct->field? > > > > I'm really not all that sure why dfr likes it so much. :-] > > I don't like it - I just thought it was "the style". If its deprecated, > then strip it all out - its ugly. Yes, it is deprecated. We build the padding directly into the *_args structs using PADL_(type) and PADR_(type). This happens to work out a lot better for the syscall argument size calculations too. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message