From owner-svn-src-all@freebsd.org Fri Jan 25 01:44:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C8DD14C6BFD; Fri, 25 Jan 2019 01:44:30 +0000 (UTC) (envelope-from devin@shxd.cx) Received: from shxd.cx (mail.shxd.cx [64.201.244.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F414391E2F; Fri, 25 Jan 2019 01:44:29 +0000 (UTC) (envelope-from devin@shxd.cx) Received: from [76.77.180.168] (port=55102 helo=eskarina.lan) by shxd.cx with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.77 (FreeBSD)) (envelope-from ) id 1gmqX4-000NgJ-AC; Thu, 24 Jan 2019 17:43:46 -0800 From: Devin Teske Message-Id: <0D1FAD4B-5E35-4CCE-AA30-E94E3534F890@FreeBSD.org> Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r343416 - head/bin/sh Date: Thu, 24 Jan 2019 17:44:15 -0800 In-Reply-To: <201901250023.x0P0NrC0085675@pdx.rh.CN85.dnsmgr.net> Cc: Devin Teske , Ian Lepore , Edward Tomasz Napierala , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: rgrimes@freebsd.org References: <201901250023.x0P0NrC0085675@pdx.rh.CN85.dnsmgr.net> X-Mailer: Apple Mail (2.3445.9.1) Sender: devin@shxd.cx X-Rspamd-Queue-Id: F414391E2F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.979,0] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 01:44:30 -0000 > On Jan 24, 2019, at 4:23 PM, Rodney W. Grimes = wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] >> On Thu, 2019-01-24 at 15:55 -0800, Rodney W. Grimes wrote: >>>> Author: trasz >>>> Date: Thu Jan 24 23:34:51 2019 >>>> New Revision: 343416 >>>> URL: https://svnweb.freebsd.org/changeset/base/343416 >>>>=20 >>>> Log: >>>> Install .shrc for root, and set PS1 for the toor account. >>>=20 >>> And a dozen other aliases :-( >>> Please do not contaiminate the prestine environment with >>> personal preferences. In the start of the project we >>> did a great deal of work to remove and eliminate these >>> types of things, only the few csh aliases where retained. >>>=20 >>> This is really the domain of a systems administrator to >>> decide and making work for them to clean this out is >>> not going to make them happy. >>>=20 >>> The commands in an ENV file well be executed by >>> every single shell that is started, not just an >>> interactive shell, unless I am mis reading the >>> man page: >>> If the environment variable ENV is set on >>> entry to a shell, or is set in the .profile of a login shell, the >>> shell >>> then subjects its value to parameter expansion and arithmetic >>> expansion >>> and reads commands from the named file. >=20 > The man page needs fixed here too, it does infact later state > that THIS version of sh does not always run ENV, only for > interactive shells. Which is a good thing, but there is > still this un needed contaimination with aliases. >=20 > You also just caused me to have to revive my .profile diff > cause the addition of the ENV falls in the context range > of my local mods. I am sure this effects others. Please > do consider that these files have been very very rarely > touched over decades of time. >=20 +1 Will be watching for the revert of this. --=20 Devin