From owner-freebsd-fs@freebsd.org Wed May 8 23:53:01 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB7D11596D67 for ; Wed, 8 May 2019 23:53:01 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670081.outbound.protection.outlook.com [40.107.67.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 743296D51B for ; Wed, 8 May 2019 23:53:00 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM (52.132.70.13) by YQBPR0101MB2115.CANPRD01.PROD.OUTLOOK.COM (52.132.72.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.15; Wed, 8 May 2019 23:52:58 +0000 Received: from YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM ([fe80::e92e:7851:66e9:3967]) by YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM ([fe80::e92e:7851:66e9:3967%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 23:52:58 +0000 From: Rick Macklem To: Peter Eriksson CC: "freebsd-fs@freebsd.org" Subject: Re: test hash functions for fsid Thread-Topic: test hash functions for fsid Thread-Index: AQHVBauTkubp5doP8E+dPPSC2TDxraZhjMQAgABX9rw= Date: Wed, 8 May 2019 23:52:58 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76bab312-60e3-4cb4-bc03-08d6d4104c56 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(49563074)(7193020); SRVR:YQBPR0101MB2115; x-ms-traffictypediagnostic: YQBPR0101MB2115: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(136003)(346002)(396003)(376002)(199004)(189003)(81166006)(81156014)(8676002)(2906002)(74316002)(446003)(256004)(5024004)(186003)(11346002)(71190400001)(6916009)(25786009)(8936002)(486006)(71200400001)(316002)(786003)(52536014)(46003)(305945005)(478600001)(5660300002)(476003)(4744005)(229853002)(14454004)(66616009)(64756008)(66476007)(66556008)(66446008)(55016002)(9686003)(99936001)(6436002)(76176011)(53936002)(86362001)(6506007)(7696005)(102836004)(33656002)(73956011)(68736007)(99286004)(6246003)(66946007)(74482002)(76116006)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB2115; H:YQBPR0101MB2260.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uMFINemAasPmwzezGe2sQDXh8ZD30vKJ9/C7TFORApd6ICDEp8hayShQlQ+WNCICNAtQCPxjDKLK7lyEE+mYbXIorY6NxMe/C5ju2FsPAYBppabU+ryHm0Y9j8MziByDiLAtJLw9FJnkGxrbDhJg0K2xN/471Fl4sG58u8ODubO6MiV00Csp/M7et+FMCzkqzhq9RchQVYyJVMwmJF0topAeK37kyQnGYCsj0zpJObpNwN3m0MPbqUTTKVNzJA8ExZw3hCLQa1absLtyJmDtCS/fQCqWxXsTXbBA+fmou0ToSu/aaNz4lHb1GcXVAYB2LKSm+IEWjYmzpNGosf7aP0/u8I7kRdEmIIgu31BiyqJpyXgb3I0zA6Dy+wGWzQtRUSuLvP4tM0S9SqUd4PI3xZXl1pqU0heE6gMzBt2rZeQ= Content-Type: multipart/mixed; boundary="_002_YQBPR0101MB2260AA6B2642A5DDE49D4A35DD320YQBPR0101MB2260_" MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 76bab312-60e3-4cb4-bc03-08d6d4104c56 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 23:52:58.4162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB2115 X-Rspamd-Queue-Id: 743296D51B X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.81 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-0.96 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.967,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-0.99)[-0.991,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_SPAM_SHORT(0.21)[0.206,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; CTYPE_MIXED_BOGUS(1.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[81.67.107.40.list.dnswl.org : 127.0.3.0]; MIME_BASE64_TEXT(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 23:53:02 -0000 --_002_YQBPR0101MB2260AA6B2642A5DDE49D4A35DD320YQBPR0101MB2260_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Peter wrote: >Here=92s the output from a couple of our servers (filur00 with around 2428= 9 zfs >filesystems, balur01 with about 72350 zfs filesystems, filur04 about= 7500 zfs >filesystems): > > >Lpeter86@filur00:~ % ./testhash >H1: max=3D24290 min=3D0 >H2: max=3D24290 min=3D0 >H3: max=3D24290 min=3D0 >H4: max=3D24290 min=3D0 > >Lpeter86@balur01:~ % /tmp/testhash >H1: max=3D73343 min=3D0 >H2: max=3D73343 min=3D0 >H3: max=3D73343 min=3D0 >H4: max=3D73343 min=3D0 > >Lpeter86@filur04:~ % /tmp/testhash >H1: max=3D7560 min=3D0 >H2: max=3D7560 min=3D0 >H3: max=3D7560 min=3D0 >H4: max=3D7560 min=3D0 > I'll admit when I first looked at this, I was baffled;-) Turns out the f_fsid field is just zeros when getmntinfo() is run by non-ro= ot. Please do this again as "root". I have attached a slightly modified version with an additional trivial hash and it calculates variance. Thanks for doing this, rick --_002_YQBPR0101MB2260AA6B2642A5DDE49D4A35DD320YQBPR0101MB2260_ Content-Type: text/plain; name="testhash.c" Content-Description: testhash.c Content-Disposition: attachment; filename="testhash.c"; size=2448; creation-date="Wed, 08 May 2019 23:52:45 GMT"; modification-date="Wed, 08 May 2019 23:52:45 GMT" Content-Transfer-Encoding: base64 I2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxlcnIuaD4KI2luY2x1ZGUgPHN5cy9wYXJhbS5o PgojaW5jbHVkZSA8c3lzL2Zudl9oYXNoLmg+CiNpbmNsdWRlIDxzeXMvaGFzaC5oPgojaW5jbHVk ZSA8c3lzL21vdW50Lmg+CgppbnQKbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQp7CglpbnQg aDFbMjU2XSwgaDJbMjU2XSwgaDNbMjU2XSwgaDRbMjU2XSwgaDVbMjU2XSwgaSwgbWF4LCBtaW4s IG51bTsKCXN0cnVjdCBzdGF0ZnMgKm1udGJ1ZnA7CglmbG9hdCBhdmUsIHZhcmksIHRvdHZhcmk7 CgoJZm9yIChpID0gMDsgaSA8IDI1NjsgaSsrKSB7CgkJaDFbaV0gPSAwOwoJCWgyW2ldID0gMDsK CQloM1tpXSA9IDA7CgkJaDRbaV0gPSAwOwoJCWg1W2ldID0gMDsKCX0KCW51bSA9IGdldG1udGlu Zm8oJm1udGJ1ZnAsIE1OVF9OT1dBSVQpOwoJaWYgKG51bSA9PSAwKQoJCWVycngoMSwgIk11c3Qg YmUgcnVuIGFzIHJvb3QiKTsKCWZvciAoaSA9IDA7IGkgPCBudW07IGkrKykgewoJCWgxW2Zudl8z Ml9idWYoJm1udGJ1ZnBbaV0uZl9mc2lkLCBzaXplb2YoZnNpZF90KSwgMCkgJSAyNTZdKys7CgkJ aDJbZm52XzMyX2J1ZigmbW50YnVmcFtpXS5mX2ZzaWQsIHNpemVvZihmc2lkX3QpLCBGTlYxXzMy X0lOSVQpICUgMjU2XSsrOwoJCWgzW2hhc2gzMl9idWYoJm1udGJ1ZnBbaV0uZl9mc2lkLCBzaXpl b2YoZnNpZF90KSwgMCkgJSAyNTZdKys7CgkJaDRbaGFzaDMyX2J1ZigmbW50YnVmcFtpXS5mX2Zz aWQsIHNpemVvZihmc2lkX3QpLCBIQVNISU5JVCkgJSAyNTZdKys7CgkJaDVbbW50YnVmcFtpXS5m X2ZzaWQudmFsWzBdICUgMjU2XSsrOwoJfQoJYXZlID0gKGZsb2F0KW51bSAvIDI1Ni4wOwoJbWlu ID0gMTAwMDAwMDA7CgltYXggPSAwOwoJdG90dmFyaSA9IDAuMDsKCWZvciAoaSA9IDA7IGkgPCAy NTY7IGkrKykgewoJCWlmIChoMVtpXSA+IG1heCkKCQkJbWF4ID0gaDFbaV07CgkJaWYgKGgxW2ld IDwgbWluKQoJCQltaW4gPSBoMVtpXTsKCQlpZiAoKGZsb2F0KWgxW2ldID4gYXZlKQoJCQl2YXJp ID0gKGZsb2F0KWgxW2ldIC0gYXZlOwoJCWVsc2UKCQkJdmFyaSA9IGF2ZSAtIChmbG9hdCloMVtp XTsKCQl0b3R2YXJpICs9IHZhcmk7Cgl9CglwcmludGYoIkgxOiBtYXg9JWQgbWluPSVkIHRvdHZh cmk9JWZcbiIsIG1heCwgbWluLCB0b3R2YXJpKTsKCW1pbiA9IDEwMDAwMDAwOwoJbWF4ID0gMDsK CXRvdHZhcmkgPSAwLjA7Cglmb3IgKGkgPSAwOyBpIDwgMjU2OyBpKyspIHsKCQlpZiAoaDJbaV0g PiBtYXgpCgkJCW1heCA9IGgyW2ldOwoJCWlmIChoMltpXSA8IG1pbikKCQkJbWluID0gaDJbaV07 CgkJaWYgKChmbG9hdCloMltpXSA+IGF2ZSkKCQkJdmFyaSA9IChmbG9hdCloMltpXSAtIGF2ZTsK CQllbHNlCgkJCXZhcmkgPSBhdmUgLSAoZmxvYXQpaDJbaV07CgkJdG90dmFyaSArPSB2YXJpOwoJ fQoJcHJpbnRmKCJIMjogbWF4PSVkIG1pbj0lZCB0b3R2YXJpPSVmXG4iLCBtYXgsIG1pbiwgdG90 dmFyaSk7CgltaW4gPSAxMDAwMDAwMDsKCW1heCA9IDA7Cgl0b3R2YXJpID0gMC4wOwoJZm9yIChp ID0gMDsgaSA8IDI1NjsgaSsrKSB7CgkJaWYgKGgzW2ldID4gbWF4KQoJCQltYXggPSBoM1tpXTsK CQlpZiAoaDNbaV0gPCBtaW4pCgkJCW1pbiA9IGgzW2ldOwoJCWlmICgoZmxvYXQpaDNbaV0gPiBh dmUpCgkJCXZhcmkgPSAoZmxvYXQpaDNbaV0gLSBhdmU7CgkJZWxzZQoJCQl2YXJpID0gYXZlIC0g KGZsb2F0KWgzW2ldOwoJCXRvdHZhcmkgKz0gdmFyaTsKCX0KCXByaW50ZigiSDM6IG1heD0lZCBt aW49JWQgdG90dmFyaT0lZlxuIiwgbWF4LCBtaW4sIHRvdHZhcmkpOwoJbWluID0gMTAwMDAwMDA7 CgltYXggPSAwOwoJdG90dmFyaSA9IDAuMDsKCWZvciAoaSA9IDA7IGkgPCAyNTY7IGkrKykgewoJ CWlmIChoNFtpXSA+IG1heCkKCQkJbWF4ID0gaDRbaV07CgkJaWYgKGg0W2ldIDwgbWluKQoJCQlt aW4gPSBoNFtpXTsKCQlpZiAoKGZsb2F0KWg0W2ldID4gYXZlKQoJCQl2YXJpID0gKGZsb2F0KWg0 W2ldIC0gYXZlOwoJCWVsc2UKCQkJdmFyaSA9IGF2ZSAtIChmbG9hdCloNFtpXTsKCQl0b3R2YXJp ICs9IHZhcmk7Cgl9CglwcmludGYoIkg0OiBtYXg9JWQgbWluPSVkIHRvdHZhcmk9JWZcbiIsIG1h eCwgbWluLCB0b3R2YXJpKTsKCW1pbiA9IDEwMDAwMDAwOwoJbWF4ID0gMDsKCXRvdHZhcmkgPSAw LjA7Cglmb3IgKGkgPSAwOyBpIDwgMjU2OyBpKyspIHsKCQlpZiAoaDVbaV0gPiBtYXgpCgkJCW1h eCA9IGg1W2ldOwoJCWlmIChoNVtpXSA8IG1pbikKCQkJbWluID0gaDVbaV07CgkJaWYgKChmbG9h dCloNVtpXSA+IGF2ZSkKCQkJdmFyaSA9IChmbG9hdCloNVtpXSAtIGF2ZTsKCQllbHNlCgkJCXZh cmkgPSBhdmUgLSAoZmxvYXQpaDVbaV07CgkJdG90dmFyaSArPSB2YXJpOwoJfQoJcHJpbnRmKCJI NTogbWF4PSVkIG1pbj0lZCB0b3R2YXJpPSVmXG4iLCBtYXgsIG1pbiwgdG90dmFyaSk7Cn0K --_002_YQBPR0101MB2260AA6B2642A5DDE49D4A35DD320YQBPR0101MB2260_--