From owner-freebsd-mobile Wed Sep 19 6: 1:12 2001 Delivered-To: freebsd-mobile@freebsd.org Received: from air.linkclub.or.jp (air.linkclub.or.jp [210.250.19.40]) by hub.freebsd.org (Postfix) with ESMTP id 8647237B415 for ; Wed, 19 Sep 2001 06:01:04 -0700 (PDT) Received: from localhost.jp.FreeBSD.org (1Cust40.tnt1.hanno.jp.da.uu.net [63.12.195.40]) by air.linkclub.or.jp (8.11.4/8.11.4) with ESMTP id f8JCvXW07400 for ; Wed, 19 Sep 2001 21:57:34 +0900 (JST) (envelope-from toshi@jp.FreeBSD.org) Date: Wed, 19 Sep 2001 21:40:51 +0900 (JST) Message-Id: <200109191240.f8JCepM89586.toshi@jp.FreeBSD.org> From: Toshihiko ARAI To: nate@yogotech.com (Nate Williams), freebsd-mobile@FreeBSD.org Subject: Re: [PATCH] pccard_ether and removable_* variables In-Reply-To: <200109191132.f8JBWeM88990.toshi@jp.FreeBSD.org> References: <15245.13394.275183.61715@nomad.yogotech.com> <200109011153.f81BrZL93078.toshi@jp.FreeBSD.org> <15253.10889.977127.513674@nomad.yogotech.com> <200109051230.f85CUGQ39840.toshi@jp.FreeBSD.org> <15254.22900.863293.94059@nomad.yogotech.com> <200109071244.f87Cib011728.toshi@jp.FreeBSD.org> <15256.60442.758729.299336@nomad.yogotech.com> <200109141452.f8EEqJF33125.toshi@jp.FreeBSD.org> <15266.6852.389169.298534@nomad.yogotech.com> <200109160641.f8G6fxf55588.toshi@jp.FreeBSD.org> <15270.11733.309708.185928@nomad.yogotech.com> <200109191132.f8JBWeM88990.toshi@jp.FreeBSD.org> X-Mailer: VM 5.96 (beta) / Mule 2.3 (SUETSUMUHANA) based on 19.34.1 Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org + <200109191132.f8JBWeM88990.toshi@jp.FreeBSD.org>, Toshihiko ARAI wrote: >> The only difference I might make it to have the static_routes_{if} >> defined in the pccard section, since otherwise it might make things >> confusing for non-removalbe users. >> #static_routes_ed0="net1" # Set to static route list for ed0 by >> # removable network interface. >> Would it be possible/advisable to rename this variable to something like >> 'removable_route_{if}' instead? That way it wouldn't be confused with >> entries used for non-removable interfaces? > I did not notice the risk. I consider this change to be good. I updated a patch as follows. http://home.jp.FreeBSD.org/~toshi/pccard-current-20010919.diff http://home.jp.FreeBSD.org/~toshi/pccard-stable-20010919.diff -- Toshihiko ARAI To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message