From owner-svn-src-all@freebsd.org Thu Jul 30 11:54:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A9373A2E34; Thu, 30 Jul 2020 11:54:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BHTNN0skQz4G3Q; Thu, 30 Jul 2020 11:54:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id F08521E285; Thu, 30 Jul 2020 11:54:27 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f181.google.com with SMTP id o22so19819698qtt.13; Thu, 30 Jul 2020 04:54:27 -0700 (PDT) X-Gm-Message-State: AOAM5310veQG9+vg13w7J01CIEqpkHBfY/EwlqjgicKQ73QHMzyAH92W 6jQAk3JCLH5ap4g9fggjn0ab9N6J0gUOR9LDGAk= X-Google-Smtp-Source: ABdhPJx9W4M3QhWQoh+aAGWskWswUee4IqP3HRemPf/KnWoy1HveDQ0NRTnseJdVVO0Vm+hQ/7m/Zg0faYoDpZBdWb0= X-Received: by 2002:ac8:7a66:: with SMTP id w6mr2583311qtt.242.1596110067577; Thu, 30 Jul 2020 04:54:27 -0700 (PDT) MIME-Version: 1.0 References: <202007292321.06TNLuoq087451@repo.freebsd.org> <270c05f8-c75d-363f-c067-18c4c4773338@freebsd.org> <20200730114856.GA21708@lion.0xfce3.net> In-Reply-To: <20200730114856.GA21708@lion.0xfce3.net> From: Kyle Evans Date: Thu, 30 Jul 2020 06:54:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r363679 - in head: contrib/netbsd-tests/lib/libc/regex/data lib/libc/regex To: Gordon Bergling Cc: =?UTF-8?B?U3RlZmFuIEXDn2Vy?= , src-committers , svn-src-all , svn-src-head , David Wolfskill Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 11:54:28 -0000 On Thu, Jul 30, 2020 at 6:48 AM Gordon Bergling wrote: > > On Thu, Jul 30, 2020 at 01:26:46PM +0200, Stefan E=C3=9Fer wrote: > > Am 30.07.20 um 01:21 schrieb Kyle Evans: > > [...] > > > This change bumps the symbol version of regcomp to FBSD_1.6 and pro= vides the > > > old escape semantics for legacy applications, just in case one has = an older > > > application that would immediately turn into a pumpkin because of a= n > > > extraneous escape that's embedded or otherwise critical to its oper= ation. > > > > I get an error during make buildworld with option WITH_TESTS=3Dyes: > > > > =3D=3D=3D> usr.bin/bmake/tests (install) > > ld-elf.so.1: /usr/src/amd64.amd64/tmp/legacy/usr/sbin/make: Undefined > > symbol "regcomp@FBSD_1.6" > > > > Regards, STefan > > I got the same error this morning and was able to solve it by doing a ful= l > buildworld without NO_CLEAN=3Dyes. > > You may want to try this in case you are using NO_CLEAN=3Dyes. > This is interesting; there shouldn't be any NO_CLEAN implications with this change. There were no dependency changes, libc should definitely get rebuilt because regcomp.c changed and thus, the libc in your objdir should have the symbol. The binary referenced above is one that we symlink into OBJDIR from the host system. I think it's also likely your problem was just fixed by the second installworld. The first one will manage to get libc installed, but not before you get errors from all the other stuff. Thanks, Kyle Evans