From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 10:05:03 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 51168D20 for ; Wed, 22 Oct 2014 10:05:03 +0000 (UTC) Received: from mail-qa0-f53.google.com (mail-qa0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 101D08BA for ; Wed, 22 Oct 2014 10:05:02 +0000 (UTC) Received: by mail-qa0-f53.google.com with SMTP id v10so2185391qac.12 for ; Wed, 22 Oct 2014 03:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=X8LxzuTyJZMOHbM0feoqjQVZd3eBQRKy7anwcIDsmwk=; b=EG0wZeZSnuuNJMcoqUMj3jER/E5hExjNNx8ES3/6ZIz0kkBfoV0aDbmM0r4ekOQfRe C8rWXkgdRPJR42BSaurgw8x0EEjLvMilJYfISh2a+dnct+SaZrZouGt3g8aytjlldktE 2LqDgtvZ+sVhnL54+pKxvQe15yYc16hiUSGZaEa78vUvQZi2wkX5D/DnjAKRBRtVPQHf HR6MeoAz6ggBJN5j8cksVhGbjiOhiBC/VNXQA0mnqNbCqrpM1fpVRghIwD1Yx8sbnRsz 7JeqsGzUhTTaDHH/3ZQwq55GAGLS/qbpvK8u/zWuye8YYHtnbYMJiAOnhkjNZRVCT9Gu JgEg== X-Gm-Message-State: ALoCoQlZMaR5ohqDQamI+qFAsK30ko62GiGdK7jkI8w+gWwZP3ZbMjzYifSCTLGWEdf5+oD6CAz6 X-Received: by 10.224.61.7 with SMTP id r7mr54975239qah.9.1413971921057; Wed, 22 Oct 2014 02:58:41 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.75.134 with HTTP; Wed, 22 Oct 2014 02:58:20 -0700 (PDT) X-Originating-IP: [2620:0:1040:404:e8f9:fd1a:c493:d286] In-Reply-To: <201410211756.s9LHu6Q9098073@svn.freebsd.org> References: <201410211756.s9LHu6Q9098073@svn.freebsd.org> From: Julio Merino Date: Wed, 22 Oct 2014 10:58:20 +0100 X-Google-Sender-Auth: Z4gI8vO2UrPvJvPbDf5C6eIrruA Message-ID: Subject: Re: svn commit: r273389 - head/contrib/netbsd-tests/lib/libc/gen To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 10:05:03 -0000 On Tue, Oct 21, 2014 at 6:56 PM, Garrett Cooper wrote: > Modified: head/contrib/netbsd-tests/lib/libc/gen/t_siginfo.c > ============================================================================== > --- head/contrib/netbsd-tests/lib/libc/gen/t_siginfo.c Tue Oct 21 17:17:40 2014 (r273388) > +++ head/contrib/netbsd-tests/lib/libc/gen/t_siginfo.c Tue Oct 21 17:56:06 2014 (r273389) > @@ -29,7 +29,9 @@ > #include > #include > > +#if defined(__NetBSD__) Every time I see this (and checks for __FreeBSD__ as well), I can't stop wondering... "why bother?" This codebase lives in the FreeBSD source tree so it should be able to assume it is being built on FreeBSD. The only thing these ifdefs achieve is bloat, because there is no way their code paths will ever be executed (and thus it's guaranteed that they will rot over time). The differences between NetBSD and FreeBSD can easily be checked by diffing the vendor branch with the contrib tree. (Plus #ifdefs based on __*BSD__ macros are usually wrong because they don't account for OS release differences and thus they will certainly also break over time.)