From owner-svn-src-head@freebsd.org  Fri Aug 28 15:43:33 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85C153B51B5;
 Fri, 28 Aug 2020 15:43:33 +0000 (UTC)
 (envelope-from freqlabs@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BdP5K2wwpz3VrH;
 Fri, 28 Aug 2020 15:43:33 +0000 (UTC)
 (envelope-from freqlabs@FreeBSD.org)
Received: from Ryans-MBP.attlocal.net (unknown
 [IPv6:2600:1700:358a:c660:44b0:df85:5e43:f180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate)
 (Authenticated sender: freqlabs/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 0FCED36E92;
 Fri, 28 Aug 2020 15:43:33 +0000 (UTC)
 (envelope-from freqlabs@FreeBSD.org)
Subject: Re: svn commit: r364863 - head
To: Harry Schmalzbauer <freebsd@omnilan.de>,
 Ryan Moeller <freqlabs@freebsd.org>, Kyle Evans <kevans@freebsd.org>,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <202008271326.07RDQbGd016044@repo.freebsd.org>
 <a60db160-df91-1ae8-630d-18dec9012147@omnilan.de>
From: Ryan Moeller <freqlabs@FreeBSD.org>
Message-ID: <1e71689e-5dca-f5cc-bc3a-177b45621431@FreeBSD.org>
Date: Fri, 28 Aug 2020 11:43:32 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <a60db160-df91-1ae8-630d-18dec9012147@omnilan.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Aug 2020 15:43:33 -0000


On 8/28/20 8:51 AM, Harry Schmalzbauer wrote:
> Am 27.08.2020 um 15:26 schrieb Ryan Moeller:
>> Author: freqlabs
>> Date: Thu Aug 27 13:26:36 2020
>> New Revision: 364863
>> URL: https://svnweb.freebsd.org/changeset/base/364863
>>
>> Log:
>>    libzfs: Also add the crypto dependency to Makefile.inc1
>>       Reported by:    kevans
>>    Discussed with:    kevans
>>    Sponsored by:    iXsystems, Inc.
>>
>> Modified:
>>    head/Makefile.inc1
>
>
> Hello,
>
> this still doesn't allwo me to compile ZFS into the kernel:
> linking kernel.full
> ld: error: undefined symbol: zfs_zstd_compress
> >>> referenced by zio_compress.c
> >>>               zio_compress.o:(zio_compress_table)
>
> ld: error: undefined symbol: zfs_zstd_decompress
> >>> referenced by zio_compress.c
> >>>               zio_compress.o:(zio_compress_table)
>
> ld: error: undefined symbol: zfs_zstd_decompress_level
> >>> referenced by zio_compress.c
> >>>               zio_compress.o:(zio_compress_table)
> *** Error code 1
>
> According to src/sys/amd64/conf/NOTES, "options ZFS" should still be 
> supported.
> Unfortunately I have no adhoc idea how to fix. Anybody else?


You need options ZSTDIO, too. NOTES needs to be updated.

-Ryan


>
> Thanks,
> -harry