From owner-p4-projects@FreeBSD.ORG  Sun Dec 23 22:56:02 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A5C7616A41A; Sun, 23 Dec 2007 22:56:02 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E01B716A419
	for <perforce@freebsd.org>; Sun, 23 Dec 2007 22:56:01 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E7EF913C447
	for <perforce@freebsd.org>; Sun, 23 Dec 2007 22:56:01 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBNMu1Fo073901
	for <perforce@freebsd.org>; Sun, 23 Dec 2007 22:56:01 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBNMu14f073852
	for perforce@freebsd.org; Sun, 23 Dec 2007 22:56:01 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Sun, 23 Dec 2007 22:56:01 GMT
Message-Id: <200712232256.lBNMu14f073852@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 131496 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Dec 2007 22:56:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=131496

Change 131496 by rwatson@rwatson_cinnamon on 2007/12/23 22:55:03

	Un-XXX one comment that is now the status quot, and remove another
	that observes what is now arguably a non-problem.

Affected files ...

.. //depot/projects/zcopybpf/src/sys/net/bpf.c#31 edit

Differences ...

==== //depot/projects/zcopybpf/src/sys/net/bpf.c#31 (text+ko) ====

@@ -616,9 +616,9 @@
 	dev->si_drv1 = d;
 
 	/*
-	 * XXXRW: For historical reasons, perform a one-time initialization
-	 * call to the buffer routines, even though we're not yet committed
-	 * to a particular buffer method.
+	 * For historical reasons, perform a one-time initialization call to
+	 * the buffer routines, even though we're not yet committed to a
+	 * particular buffer method.
 	 */
 	bpf_buffer_init(d);
 	d->bd_bufmode = BPF_BUFMODE_DEFAULT;
@@ -688,11 +688,6 @@
 	BPFD_LOCK(d);
 	d->bd_pid = curthread->td_proc->p_pid;
 	if (d->bd_bufmode != BPF_BUFMODE_BUFFER) {
-		/*
-		 * XXXRW: For now, we don't implement a uiomove for the
-		 * scatter-gather buffers associated with BPF_BUFMODE_ZBUF,
-		 * so simply disallow read().
-		 */
 		BPFD_UNLOCK(d);
 		return (EOPNOTSUPP);
 	}