From owner-svn-src-head@freebsd.org Thu Jun 14 04:44:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A4D4101F844; Thu, 14 Jun 2018 04:44:35 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2ED7871BFE; Thu, 14 Jun 2018 04:44:35 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 1EF8C2565; Thu, 14 Jun 2018 04:44:35 +0000 (UTC) Date: Thu, 14 Jun 2018 04:44:35 +0000 From: Alexey Dokuchaev To: Bryan Drewery Cc: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335042 - head/usr.bin/top Message-ID: <20180614044435.GA94219@FreeBSD.org> References: <201806130852.w5D8qKd4094584@repo.freebsd.org> <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 04:44:35 -0000 On Wed, Jun 13, 2018 at 05:01:35PM -0700, Bryan Drewery wrote: > ... > Also I really abhor rewriting anything that's not broken as it causes > merge conflict pain downstream and just adds regression risk. +1. I'm still having mixed feelings about top(1) de-contrib and rewrite. At the very least, it should not be MFC'ed until it matures long enough in -CURRENT and all regressions are found and fixed (they pop up here and there now). Currently top(1) is still a pessimization compared to what it was before, so there's a lot to catch up with. ./danfe