From owner-freebsd-multimedia@FreeBSD.ORG Sat Jan 20 02:31:10 2007 Return-Path: X-Original-To: multimedia@freebsd.org Delivered-To: freebsd-multimedia@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E9ADF16A401 for ; Sat, 20 Jan 2007 02:31:10 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.234]) by mx1.freebsd.org (Postfix) with ESMTP id 9EE5113C43E for ; Sat, 20 Jan 2007 02:31:10 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wx-out-0506.google.com with SMTP id s18so640654wxc for ; Fri, 19 Jan 2007 18:31:10 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=LdKMfc/UFib6O+TJUDtDNkeogDRyg4w+XHdDjP5rG0g0hA/QOcve4LtqXE4kLYjwdc27cF9/9TIUMcAwt7JiHT5dPNRqpypNHWPlD/fNfU+mCZj6gXSvVMo/qm6Z+Icx4JkjLyF5VMB5xOGxkeu1mgotSi8kLH9GipInLMRh5xo= Received: by 10.70.87.11 with SMTP id k11mr5081187wxb.1169258537181; Fri, 19 Jan 2007 18:02:17 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id 26sm4722958wra.2007.01.19.18.02.10; Fri, 19 Jan 2007 18:02:16 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l0K22eGD022023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 20 Jan 2007 11:02:40 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l0K22dTN022022; Sat, 20 Jan 2007 11:02:39 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sat, 20 Jan 2007 11:02:38 +0900 From: Pyun YongHyeon To: Christian Brueffer Message-ID: <20070120020238.GB17584@cdnetworks.co.kr> References: <20070119180626.GB1837@haakonia.hitnet.RWTH-Aachen.DE> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070119180626.GB1837@haakonia.hitnet.RWTH-Aachen.DE> User-Agent: Mutt/1.4.2.1i Cc: multimedia@FreeBSD.org Subject: Re: snd_envy24(4) and snd_envy24ht(4) MFC X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2007 02:31:11 -0000 On Fri, Jan 19, 2007 at 07:06:26PM +0100, Christian Brueffer wrote: > Hey guys, > > are there any plans to MFC the snd_envy24(4) and snd_envy24ht drivers? > Just read a question from someone who is looking for these in STABLE. > I have no objections on MFCing envy24(4)/envy24ht(4). But before MFCing the driver to STABLE it would be even better to clean up the driver first. For instance, apart from several style(9) nits, it still has a couple of vtophys(9) calls which should be converted to use bus_dma(9) and lots of debugging code which were disabled with '#ifdef 0'. Personally, I think these debugging code/output should be controlled in runtime with sysctls or bootverbose option. I should have made envy24ht(4) work on ONKYO SE-150PCI, but other activities for FreeBSD network drivers and paid work prevent me from fixing the code. -- Regards, Pyun YongHyeon