From owner-svn-ports-head@freebsd.org Thu Nov 12 02:40:11 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 140D8A2B819; Thu, 12 Nov 2015 02:40:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F350D14E2; Thu, 12 Nov 2015 02:40:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id ED23D12A6; Thu, 12 Nov 2015 02:40:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id AA0F113434; Thu, 12 Nov 2015 02:40:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id tcc3taA5UFie; Thu, 12 Nov 2015 02:40:08 +0000 (UTC) Subject: Re: svn commit: r401299 - head/security/openssh-portable/files DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com DC84C1342A To: Alexey Dokuchaev References: <201511112121.tABLLjO6051679@repo.freebsd.org> <20151112021225.GB43902@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Bryan Drewery Organization: FreeBSD Message-ID: <5643FC04.4020001@FreeBSD.org> Date: Wed, 11 Nov 2015 18:40:04 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151112021225.GB43902@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 02:40:11 -0000 On 11/11/15 6:12 PM, Alexey Dokuchaev wrote: > On Wed, Nov 11, 2015 at 09:21:45PM +0000, Bryan Drewery wrote: >> New Revision: 401299 >> URL: https://svnweb.freebsd.org/changeset/ports/401299 >> >> Log: >> Make portlint stop spamming me. It's gotten quite silly. > > I hope this is a temporary measure, even though portlint(1) can indeed > get annoying at times. That said, I still don't see the problem with > simply ignoring warnings that do not apply in certain particular case. > >> WARN: /root/svn/ports/security/openssh-portable/files/patch-auth.c: >> patch was not generated using ``make makepatch''. It is recommended >> to use ``make makepatch'' when you need to [re-]generate a patch to >> ensure proper patch format. > > As John had said on IRC, this helps to get consistent patches, because > prople rarely think about these little details ("repo churn? who cares > about it") and portlint(1) warning gives them simple and straight course > of action. Yet it's true that the check could probably be made somewhat > smarter than simple grepping for "UTC". > > TL;DR: instead of adding noise to the patches, it's better to improve > portlint(1). Or learn how to ignore its warnings. ;-) > We should just ignore portlint at our own discretion since it grows stupid warnings like this? Mission accomplished? -- Regards, Bryan Drewery