Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Mar 2021 20:56:38 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 253844] [NEW PORT] net/opensips24 net/opensips31
Message-ID:  <bug-253844-7788-8oS9GN2kzS@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-253844-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-253844-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253844

daniel.engberg.lists@pyret.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.engberg.lists@pyret.
                   |                            |net

--- Comment #2 from daniel.engberg.lists@pyret.net ---
Thanks for contributing!

OpenSIPS 2.4.x
https://www.opensips.org/About/AvailableVersions - Supported until: 24th of=
 May
2021

Seems to be a very little to reason to have it in tree for 2 months?

Please attach patches as diff/patch files

A few things I spotted having a quick look

PORTVERSION --> DISTVERSION
https://docs.freebsd.org/en/books/porters-handbook/book.html
"Table 5.2. Package Naming Examples"

MASTER_SITES: http --> https (redirects to https)

Is it much work to get rid of gtar and ginstall as build deps?

GCC requirement: Just for 11, all versions, specific arch?

Does shebangfix really work on *.php files since it's not set as a dependen=
cy
and is it a missing dependency?

Can't we reuse MAKE_ENV from framework instead of working around it?

do-configure seems a bit out of place, this should be in post-patch?

do-build can most likely use ports framework, see "5.13.3.11. Generic Varia=
bles
Replacement"

"@${ECHO_CMD} "Stripping binaries in"... I understand the idea but we don't=
 do
this anywhere else in tree.

Do we need to use a lot of loops for stripping binaries or can this be redu=
ced?

Try to fix as many issues as possible reported by portlint and portfmt

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253844-7788-8oS9GN2kzS>