From owner-dev-commits-ports-main@freebsd.org Wed Apr 28 12:58:01 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6FAFD5F2DEF; Wed, 28 Apr 2021 12:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FVdw92kcQz4dll; Wed, 28 Apr 2021 12:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4C3886708; Wed, 28 Apr 2021 12:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 13SCw1SY031893; Wed, 28 Apr 2021 12:58:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 13SCw1b3031892; Wed, 28 Apr 2021 12:58:01 GMT (envelope-from git) Date: Wed, 28 Apr 2021 12:58:01 GMT Message-Id: <202104281258.13SCw1b3031892@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: git: 0e66f4260178 - main - shells/modernish: Fix build MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: 0mp X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0e66f4260178b5e9528cd6009d4c3c735bf46350 Auto-Submitted: auto-generated X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 12:58:01 -0000 The branch main has been updated by 0mp: URL: https://cgit.FreeBSD.org/ports/commit/?id=0e66f4260178b5e9528cd6009d4c3c735bf46350 commit 0e66f4260178b5e9528cd6009d4c3c735bf46350 Author: Mateusz Piotrowski <0mp@FreeBSD.org> AuthorDate: 2021-04-28 12:47:43 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2021-04-28 12:57:47 +0000 shells/modernish: Fix build It looks like modernish requires /dev/tty to be available during the installation as it tries to run its install-time test suite. A solution to that is wrapping ./install.sh with script(1) to make a TTY available. Interestingly, if we replace script(1) with daemon(8), we can reproduce the error present in the pkg fallout logs. --- shells/modernish/Makefile | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/shells/modernish/Makefile b/shells/modernish/Makefile index 1a708410c92c..44a444f33226 100644 --- a/shells/modernish/Makefile +++ b/shells/modernish/Makefile @@ -16,14 +16,10 @@ NO_BUILD= yes OPTIONS_DEFINE= DOCS EXAMPLES -post-extract: - ${MV} ${WRKSRC}/lib/modernish/cap/BUG_DEVTTY.t ${WRKDIR} - do-install: cd ${WRKSRC} && \ - ${SETENV} ${MAKE_ENV} ${SH} -x ./install.sh -d ${PREFIX} -D ${STAGEDIR} -n -s ${SH} - - ${INSTALL_DATA} ${WRKDIR}/BUG_DEVTTY.t ${STAGEDIR}${PREFIX}/lib/modernish/cap/BUG_DEVTTY.t + ${SETENV} ${MAKE_ENV} script -q /dev/stdout \ + ${SH} -x ./install.sh -d ${PREFIX} -D ${STAGEDIR} -n -s ${SH} ${RM} ${STAGEDIR}${DOCSDIR}/LICENSE ${MKDIR} ${STAGEDIR}${EXAMPLESDIR:H}