From owner-freebsd-ports@FreeBSD.ORG Mon Jan 17 20:18:07 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 856ED106564A for ; Mon, 17 Jan 2011 20:18:07 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward9.mail.yandex.net (forward9.mail.yandex.net [77.88.61.48]) by mx1.freebsd.org (Postfix) with ESMTP id B41828FC12 for ; Mon, 17 Jan 2011 20:18:06 +0000 (UTC) Received: from smtp7.mail.yandex.net (smtp7.mail.yandex.net [77.88.61.55]) by forward9.mail.yandex.net (Yandex) with ESMTP id 2363C14D8B03; Mon, 17 Jan 2011 23:15:13 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1295295313; bh=Amgqdn33GD9CjVfXPlA+Xnf2+9vJlQjFBLumkuY41Jg=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=akBdVL7GBmRLIwYWeSktq2UZLXJ95jrxeyaky568kSTQKtoDy0qOW+WqP/9kNlm8O nBNCr7hnrrC6k0s7wt/+fXAnj92JW2t0xvx5mUNry6o/wjPLuQ0v44OGZEVuASCfgu tY4og+VdMkNyhYElS/5tjP+8/gZewkQO6mwuv3d8= Received: from smeshariki2.local (unknown [213.138.87.92]) by smtp7.mail.yandex.net (Yandex) with ESMTPSA id DE9FC1C60071; Mon, 17 Jan 2011 23:15:12 +0300 (MSK) Message-ID: <4D34A312.8060808@yandex.ru> Date: Mon, 17 Jan 2011 23:14:10 +0300 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; ru-RU; rv:1.9.2.13) Gecko/20110106 Thunderbird/3.1.7 MIME-Version: 1.0 To: Jason Helfman References: <11111295127072@web122.yandex.ru> <4D3329FE.7020901@yandex.ru> <20110116204416.GA1654@eggman.experts-exchange.com> <4D3361B3.40201@yandex.ru> <20110116214557.GA2179@eggman.experts-exchange.com> In-Reply-To: <20110116214557.GA2179@eggman.experts-exchange.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: ports@freebsd.org Subject: Re: New port needs review: net/erlyvideo X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2011 20:18:07 -0000 17.01.2011 00:45, Jason Helfman пишет: >>> You may wish to consider a for loop on the make install target. >>> Are these directories created during the install process of the >>> package? I >>> didn't see these directories created outside of the Makefile. >> >> Do you mean something like this? >> >> DIRS= /var/lib/${PORTNAME}/movies /var/lib/${PORTNAME}/plugins \ >> /var/log/${PORTNAME} ${ERLYDIR} ${ETCDIR} ${WWWDIR} >> .for dir in ${DIRS} >> ${MKDIR} ${dir} >> .endfor > > Yes, however are they created during a pkg_add command? Consider a recent > patch I submitted for comms/minicom. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153749 > > Directories created in Makefile process, aren't created in the packaging > process, unless you are putting the operations into a pkg-install or an > @exec operation in pkg-plist, respectively. > > That is my understanding, and what I have found in fixing ports here and > there. I fixed the packaging for www/tomcat55, as well. I found that as a > port it worked fine, however package installation would fail. Jason, i fixed all the issues that you mentioned besides this one. 1. "for" loop somehow doesn't work for ${ETCDIR}, ${WWWDIR}, ${ERLDIR} in Makefile. I tried to add this lines and it fails to create this directories: """ .for dir in /var/lib/${PORTNAME}/movies /var/lib/${PORTNAME}/plugins \ /var/log/${PORTNAME} ${ETCDIR} ${ERLYDIR} ${WWWDIR} ${MKDIR} ${dir} .endfor """ But dirs in /var still created fine. 2. When i do a `make package` then i see that in created package directories and files that installed into /var/lib/${PORTNAME} and /var/log/${PORTNAME} are missing (still ${ETCDIR}, ${WWWDIR}, ${ERLDIR} added to package without any problem). This directories is created in filesystem, but missing in package file. I read http://www.freebsd.org/doc/en/books/porters-handbook/plist-cleaning.html and PR 153749 but it doesn't help much. Directories in /var are created, but not included into a package. How can i fix that? -- Regards, Ruslan