From owner-svn-ports-head@FreeBSD.ORG Mon Jul 28 18:44:06 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 30060297 for ; Mon, 28 Jul 2014 18:44:06 +0000 (UTC) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 969C72227 for ; Mon, 28 Jul 2014 18:44:05 +0000 (UTC) Received: by mail-lb0-f170.google.com with SMTP id w7so6171185lbi.1 for ; Mon, 28 Jul 2014 11:44:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=ANyOHueO5ZFt06SYEzhiR2/BsHkDsxM7QdeN9LWFJMM=; b=dXTAtg+Uo8JszkiowyjnpFtKDg2MslhYdwoW7abjFGuILl35xfLKtm2pqLw0TFrq6g keLoybp6o5G6jm+56oEJV22jU0QLCY2/NBIetcU7kyXdSDnb1G5jyFls0wXhCEdmZNQW 8Jcwpd7TG6CTFAOsFfYhWeisvNLPAH13nsRaixpIkJzHuHeuGUZHN3j/W/17ETP22djv OcocMJ5DKoSRWsXW5C8fShsH8brm32ZI7eOPfYHOIz1j9BWNyAcemkDxrhhX/lyu25+R Pzv7TE+/JStO88ypnbHfPTeFIOqArdTzlsOR6m4U+XzretYt9hoAcX7Lyg50OrB9r88P 2Dug== X-Gm-Message-State: ALoCoQkI8pEHaWB20YsKJY/q3fpUBzzp0emB0YXWY4N4pVfes//G/+wUFwRBL40EVMM7c5a0dX/x X-Received: by 10.152.36.225 with SMTP id t1mr24776509laj.65.1406573041800; Mon, 28 Jul 2014 11:44:01 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.161.100 with HTTP; Mon, 28 Jul 2014 11:43:41 -0700 (PDT) In-Reply-To: <201407281608.s6SG81SC042694@svn.freebsd.org> References: <201407281608.s6SG81SC042694@svn.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Tue, 29 Jul 2014 02:43:41 +0800 X-Google-Sender-Auth: BQiYRRT3CYUqhxf3t4K9589L8mA Message-ID: Subject: Re: svn commit: r363195 - in head/devel: p5-Module-Build p5-Module-Build-Tiny To: Mathieu Arnold Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2014 18:44:06 -0000 On Tue, Jul 29, 2014 at 12:08 AM, Mathieu Arnold wrote: > Author: mat > Date: Mon Jul 28 16:08:00 2014 > New Revision: 363195 > URL: http://svnweb.freebsd.org/changeset/ports/363195 > QAT: https://qat.redports.org/buildarchive/r363195/ > > Log: > Reword the comment here so that updating the build depends version is not > forced here if it is not needed. > > With hat: perl@ > Sponsored by: Absolight > > Modified: > head/devel/p5-Module-Build-Tiny/Makefile > head/devel/p5-Module-Build/Makefile > > Modified: head/devel/p5-Module-Build-Tiny/Makefile > > ============================================================================== > --- head/devel/p5-Module-Build-Tiny/Makefile Mon Jul 28 16:03:51 2014 > (r363194) > +++ head/devel/p5-Module-Build-Tiny/Makefile Mon Jul 28 16:08:00 2014 > (r363195) > @@ -1,8 +1,9 @@ > # Created by: Sunpoet Po-Chuan Hsieh > # $FreeBSD$ > # > -# Do not forget to update p5-Module-Build-Tiny version in Mk/Uses/ > perl5.mk > -# while updating this port! > +# If you have compelling evidence that some ports need at least this > version of > +# p5-Module-Build-Tiny to build, be sure to update the BUILD_DEPENDS > version in > +# Mk/Uses/perl5.mk. > > PORTNAME= Module-Build-Tiny > PORTVERSION= 0.037 > > Modified: head/devel/p5-Module-Build/Makefile > > ============================================================================== > --- head/devel/p5-Module-Build/Makefile Mon Jul 28 16:03:51 2014 > (r363194) > +++ head/devel/p5-Module-Build/Makefile Mon Jul 28 16:08:00 2014 > (r363195) > @@ -1,8 +1,9 @@ > # Created by: Dmitry Sivachenko > # $FreeBSD$ > # > -# Do not forget to update p5-Module-Build version in Mk/Uses/perl5.mk > -# while updating this port! > +# If you have compelling evidence that some ports need at least this > version of > +# p5-Module-Build to build, be sure to update the BUILD_DEPENDS version in > +# Mk/Uses/perl5.mk. > > PORTNAME= Module-Build > PORTVERSION= 0.4206 > > Hi mat, Thanks for your rewording. It's more clear now. Let me explain why I added the original comment. I think it's harmless to use latest version in most cases. To my experience, (my) ports using Module::Build::Tiny usually require up-to-date version. Recent examples: - devel/p5-MooseX-Types-DateTime-MoreCoercions 0.12 (Jul 21, 2014) requires Module::Build::Tiny 0.036 (May 2, 2014). - devel/p5-MooseX-Runnable 0.07 (Feb 18, 2014) requires Module::Build::Tiny 0.035 (Feb 17, 2014). Therefore, I'l update Mk/Uses/perl5.mk along with devel/p5-Module-Build-Tiny. The comment here can be removed I guess. :) I don't have Module::Build case in hand. Regards, sunpoet