From owner-svn-src-all@FreeBSD.ORG Thu Jan 15 15:25:59 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 421D472A; Thu, 15 Jan 2015 15:25:59 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 196BBFDB; Thu, 15 Jan 2015 15:25:59 +0000 (UTC) Received: from new-host-2.home (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6C3CBB94B; Thu, 15 Jan 2015 10:25:57 -0500 (EST) Message-ID: <54B7DC05.6080801@FreeBSD.org> Date: Thu, 15 Jan 2015 10:25:57 -0500 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Warner Losh Subject: Re: svn commit: r277163 - head/sys/dev/cardbus References: <201501140541.t0E5fV00070032@svn.freebsd.org> <54B67BC9.70904@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 15 Jan 2015 10:25:57 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 15:25:59 -0000 On 1/14/15 7:07 PM, Warner Losh wrote: > >> On Jan 14, 2015, at 7:23 AM, John Baldwin wrote: >> >> On 1/14/15 12:41 AM, Warner Losh wrote: >>> Author: imp >>> Date: Wed Jan 14 05:41:31 2015 >>> New Revision: 277163 >>> URL: https://svnweb.freebsd.org/changeset/base/277163 >>> >>> Log: >>> Add a rather obnoxious warning if you don't have NEW_PCIB defined >>> since it's a total crap shoot if things will work. >> >> Should we just make it a #error instead? (Some day I hope to have >> NEW_PCIB enabled by default and remove the old code. Will take a while >> to get there for the generic PCI code, but cardbus is probably only used >> on x86 so that would be fine.) > > CardBus is also used on PowerPC macs.. Ok. It shouldn't be hard to add the PCI_RES_BUS stuff to PowerPC. I believe I put the details of that in the NEW_PCIB page on the wiki. You just need to have the equivalent of the x86 nexus call some MI routines to allocate bus numbers for a given domain when bus_alloc_resource() requests bubble up from below. -- John Baldwin