Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Feb 2018 01:00:46 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r329777 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <201802220100.w1M10kDO022820@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Thu Feb 22 01:00:46 2018
New Revision: 329777
URL: https://svnweb.freebsd.org/changeset/base/329777

Log:
  MFV r329776: 8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa)
  
  illumos/illumos-gate@f4c1745bd6c9829a05ecec15759ede7757100ab5
  
  Illumos 4080 allows "zpool clear" to work on readonly pools: i don't think
  this is the intended behaviour, we shouldn't be allowed to clear readonly
  pools. Probably.
  
  A fix is already in the ZFS on Linux repository to addess this issue:
  https://github.com/zfsonlinux/zfs/commit/92e43c17188d47f47b69318e4884096dec380e36
  
  Reviewed by: Matthew Ahrens <mahrens@delphix.com>
  Approved by: Dan McDonald <danmcd@joyent.com>
  Author: loli10K <ezomori.nozomu@gmail.com>

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
Directory Properties:
  head/sys/cddl/contrib/opensolaris/   (props changed)

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c	Thu Feb 22 00:59:49 2018	(r329776)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c	Thu Feb 22 01:00:46 2018	(r329777)
@@ -6172,7 +6172,7 @@ zfs_ioctl_init(void)
 	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_NONE);
 
 	zfs_ioctl_register_pool(ZFS_IOC_CLEAR, zfs_ioc_clear,
-	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_NONE);
+	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_READONLY);
 	zfs_ioctl_register_pool(ZFS_IOC_POOL_REOPEN, zfs_ioc_pool_reopen,
 	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_SUSPENDED);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201802220100.w1M10kDO022820>