From nobody Thu Jan 8 08:52:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dmzDS01WPz62Zsv for ; Thu, 08 Jan 2026 08:52:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dmzDR6GzTz3hs9 for ; Thu, 08 Jan 2026 08:52:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767862327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HeCaxEtBOJZx12CBrkVxS9rNKYzWXrIuWIyYVghqx+8=; b=nrPtKp/+CxFRlHnUvj+k6tG7wkCA50SqZDMgbcUMkwFWyn22oVrKPeHerMdgOYRS271Pdb pLDG08t8UctAFUTg/1grMx0g3NugDK314sl2CuAjbWu3TW8+GAE0VA17cb//5ecE5k1VM7 3ac1B5I833NzYQfGF6qAME8Te2N3gkqGCo6nE4xdjXIEfKzI33eIbtOtHDB+LmB57yk3wz 9tgpmZDDVqfWlJhr0vuJB1v6eqLHzSQeGYsVAmMLa3hUxs6wm3b7dfRrzGw/HJOfqbDiZ5 h+OuNwDwus+g3pgr7DrtFwRV8X8REIh+AAZXLXPVN7/ySyk8I1/1gWlndU7tew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767862327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HeCaxEtBOJZx12CBrkVxS9rNKYzWXrIuWIyYVghqx+8=; b=FYOdzhVk6LOVaDvq0S6+Dwtmc1+4boMp7WqL1l+M5KNmzSWTZBQYM5YXYWbaYTVuD3gWVD ZhaX0WlOZBECxRcDBZ9qjZEbsNy6pmlCn/xBJtw1zDLexTd/g3J7kVZ/xXb0x+rJuS5R4M RM5sWfsKYhO03St9w0myaLkx+dATqzmCLnUeK4h3iCwlBehXrgC/zQBODFjbJbO/SNIcas EiZSj88h7z2Lb4g+QxN0euS+OrIm7ftm9ge0vbRCD3/LCo4KQ8qLrALDCgWhJUPr74dQHR LERXXJejBl9G8Ln/xFOxJ6qXTwdYSdKmGvdmEaDKFoiN5qS3Vvfs9uX4VRIllg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767862327; a=rsa-sha256; cv=none; b=nrpx1E1EyTpLeZxir7XkPrB+vWe6mp56tf5GukroH31iDw3oRISPFLBpVCyCKbM9sg7IxM X3R3FGHCTP6TqfV1BnqonP7DkLReNzT0d6PCCoYQdr3XDdhICqZQKt/6ssUL2pZrtGe041 fF4KgVc/6hiiX94cK7zrHRydbrI59DwIF1U+YQS9vt15enS1tKwAi+4pbM9nSHx+aqAfPV qJqxIST4vUA1L/xCi7OD/f4Pu0Ye5f7SbZomETnJojpuVTsxAofqqfcjnmP39R7X+j93rt TiyW7/dOE4fMHo2HvqNE8LByfhVWMQPYkWEvvtTN+tJAYv+/8KXT0YTji4DDaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dmzDR5nTDzXX7 for ; Thu, 08 Jan 2026 08:52:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id ef9a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 08 Jan 2026 08:52:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: eb1b6ec7a79a - main - zfs: emit .note.GNU-stack section for all ELF targets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: eb1b6ec7a79aff05f5f10e1d6b1c63a0d8dc5f2f Auto-Submitted: auto-generated Date: Thu, 08 Jan 2026 08:52:07 +0000 Message-Id: <695f7037.ef9a.6211cd34@gitrepo.freebsd.org> The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=eb1b6ec7a79aff05f5f10e1d6b1c63a0d8dc5f2f commit eb1b6ec7a79aff05f5f10e1d6b1c63a0d8dc5f2f Author: Dimitry Andric AuthorDate: 2026-01-08 08:35:13 +0000 Commit: Dimitry Andric CommitDate: 2026-01-08 08:51:36 +0000 zfs: emit .note.GNU-stack section for all ELF targets On FreeBSD, linking the zfs kernel module with binutils ld 2.44 shows the following warning: ld: warning: aesni-gcm-avx2-vaes.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker Some of the `.S` files under `module/icp/asm-x86_64/modes` check whether to emit the `.note.GNU-stack` section using: #if defined(__linux__) && defined(__ELF__) We could add `&& defined(__FreeBSD__)` to the test, but since all other `.S` files in the OpenZFS tree use: #ifdef __ELF__ it would seem more logical to use that instead. Any recent ELF platform should support these note sections by now. Reviewed by: emaste, kib, imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D54578 --- sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S | 2 +- sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S | 2 +- sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S index 3d1b045127e2..76ced8ebad3d 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S @@ -1316,7 +1316,7 @@ SET_SIZE(aes_gcm_dec_update_vaes_avx2) #endif /* !_WIN32 || _KERNEL */ /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S index 49671f1fc46a..2e0a88ec8cef 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S @@ -1275,7 +1275,7 @@ SECTION_STATIC #endif /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S index 319caa4e190b..6c5bbf0fb272 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S @@ -714,7 +714,7 @@ SET_OBJ(.Lrem_8bit) .balign 64 /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif