From owner-svn-src-all@FreeBSD.ORG Wed Jan 7 20:46:37 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AD72FBC; Wed, 7 Jan 2015 20:46:37 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C9BA1CF3; Wed, 7 Jan 2015 20:46:35 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t07KkWfb093150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 7 Jan 2015 23:46:32 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t07KkVtB093149; Wed, 7 Jan 2015 23:46:31 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 7 Jan 2015 23:46:31 +0300 From: Gleb Smirnoff To: Craig Rodrigues , Nikos Vassiliadis Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <20150107204631.GG15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201501060903.t06934qp081875@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2015 20:46:37 -0000 On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: C> Author: rodrigc C> Date: Tue Jan 6 09:03:03 2015 C> New Revision: 276747 C> URL: https://svnweb.freebsd.org/changeset/base/276747 C> C> Log: C> Instead of creating a purge thread for every vnet, create C> a single purge thread and clean up all vnets from this thread. C> C> PR: 194515 C> Differential Revision: D1315 C> Submitted by: Nikos Vassiliadis I am not sure that this is a good idea. The core idea of VNETs is that they are isolated from each other. If we serialize purging, then vnets are strongly affecting each other. AFAIU, from the PR there is some panic fixed. What is the actual bug and why couldn't it be fixed with having per-vnet thread? -- Totus tuus, Glebius.