From owner-cvs-all  Sat May 19 22:55:51 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1B83A37B422; Sat, 19 May 2001 22:55:46 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id PAA16941;
	Sun, 20 May 2001 15:55:43 +1000
Date: Sun, 20 May 2001 15:54:17 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Kris Kennaway <kris@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/mk bsd.sys.mk Makefile bsd.kmod.mk      
   bsd.lib.mk bsd.prog.mk
In-Reply-To: <200105192318.f4JNIMp86494@freefall.freebsd.org>
Message-ID: <Pine.BSF.4.21.0105201548240.42146-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sat, 19 May 2001, Kris Kennaway wrote:

> kris        2001/05/19 16:18:21 PDT
> 
>   Modified files:
>     share/mk             Makefile bsd.kmod.mk bsd.lib.mk 
>                          bsd.prog.mk 
>   Added files:
>     share/mk             bsd.sys.mk 
>   Log:
>   Bring in the WARNS directive from NetBSD, localized in a new bsd.sys.mk
>   to avoid polluting sys.mk.  This directive controls the addition of
>   compiler warning flags to CFLAGS in a relatively compiler-neutral manner.
>   
>   The idea is that WARNS can be set in Makefile.inc or in individual
>   Makefiles as they become clean, to prevent the introduction of new
>   warnings in the code.  -Werror is added by default

Please don't clutter individual Makefiles with it.

I think it would be more useful to fix all the bugs reported with the
standard warning flags (-Wall for src/bin, lots for kernels, but none
for everything else) first.  The output from `make -ss' should be null,
but is currently almost 100K.  -Wall in individual Makefiles has had
a negative effect in preventing new warnings (it causes so many warnings
that people ignore them all).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message