From owner-freebsd-commit  Mon Sep 18 21:50:18 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id VAA02655
          for freebsd-commit-outgoing; Mon, 18 Sep 1995 21:50:18 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id VAA02639
          for cvs-all-outgoing; Mon, 18 Sep 1995 21:50:15 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id VAA02623
          for cvs-ports-outgoing; Mon, 18 Sep 1995 21:50:13 -0700
Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id VAA02613
          ; Mon, 18 Sep 1995 21:50:09 -0700
Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.6.12/8.6.12) id VAA05218; Mon, 18 Sep 1995 21:49:53 -0700
From: "Rodney W. Grimes" <rgrimes@GndRsh.aac.dev.com>
Message-Id: <199509190449.VAA05218@GndRsh.aac.dev.com>
Subject: Re: cvs commit: ports/utils/ispell/scripts configure
To: jmz@cabri.obs-besancon.fr (Jean-Marc Zucconi)
Date: Mon, 18 Sep 1995 21:49:53 -0700 (PDT)
Cc: CVS-commiters@freefall.freebsd.org, cvs-ports@freefall.freebsd.org
In-Reply-To: <9509190407.AA26129@cabri.obs-besancon.fr> from "Jean-Marc Zucconi" at Sep 19, 95 05:07:59 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1173      
Sender: owner-commit@FreeBSD.org
Precedence: bulk

> 
> >>>>> Rodney W Grimes writes:
> 
>  >> 
>  >> jmz         95/09/18 16:36:44
>  >> 
>  >> Added:       utils/ispell/patches  patch-ab
>  >> Log:
>  >> A hack to avoid recompiling everything during install
>  >> 
>  >> Modified:    utils/ispell/scripts  configure
>  >> Log:
>  >> Compile with -O2 -fno-strength-reduce
> 
>  > PLEASE, can ports use the default value of CFLAGS unless there is some
>  > very imporatant reason to override them.  If I want -O2 -fno-strength-reduce
>  > I will set it in /etc/make.conf.
> 
> This is not always possible. In this case, CFLAGS was hardcoded in a
> file (and the flags need to be between quotes). 
> On the other hand, if one want to use the defaults from
> /etc/make.conf, it is necessary to modify the makefiles so that they
> include /etc/make.conf.
> Of course the best solution would be to bmake all the ports :-)

make.conf is pulled in by sys.mk, ALL makes pull in sys.mk, gmakes do not.
ispell uses standard make, it should _NOT_ have hard coded CFLAGS in it.



-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD