From owner-p4-projects@FreeBSD.ORG  Sun Feb 22 02:40:35 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CF7FF1065673; Sun, 22 Feb 2009 02:40:34 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8C822106564A;
	Sun, 22 Feb 2009 02:40:34 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 5DE318FC1D;
	Sun, 22 Feb 2009 02:40:34 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n1M2eXEp008758
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 21 Feb 2009 18:40:34 -0800 (PST) (envelope-from sam@freebsd.org)
Message-ID: <49A0BB21.1090706@freebsd.org>
Date: Sat, 21 Feb 2009 18:40:33 -0800
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.18 (X11/20081209)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= <gabor@freebsd.org>
References: <200902220119.n1M1JljJ020105@repoman.freebsd.org>
	<49A0B129.6030308@freebsd.org> <49A0B6AC.9000303@FreeBSD.org>
In-Reply-To: <49A0B6AC.9000303@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-DCC-CollegeOfNewCaledonia-Metrics: ebb.errno.com; whitelist
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	"David E. O'Brien" <obrien@freebsd.org>
Subject: Re: PERFORCE change 158046 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Feb 2009 02:40:35 -0000

Gábor Kövesdán wrote:
> Sam Leffler escribió:
>> Gabor Kovesdan wrote:
>>> http://perforce.freebsd.org/chv.cgi?CH=158046
>>>
>>> Change 158046 by gabor@gabor_server on 2009/02/22 01:19:13
>>>
>>>     - Add support for GREP_OPTIONS
>>>       
>>
>> How many apps take options via the environment?  Not sure I like 
>> this--I can imagine very confusing situations caused by 
>> unseen/unnoticed environment variables.
> You're right, it might by dangerous if it is misused, but GNU grep 
> uses it so we should support this to maintain compatibility. And in 
> some cases, it can be really useful, imagine that you always want to 
> colorize the output, you can just set GREP_OPTIONS="--color". I'd say 
> that those who don't like it, can just ignore this and don't use it 
> all, while others who have been using it can keep using it, that's 
> fair enough.
> (CC'd obrien@ as he was the proposer, who reminded me of this missing 
> feature.)
>
I looked at ls(1); it has env variables for specific features (like 
colors).  I can buy that more than an arbitrary set of options.  If we 
want apps to take cmd line args from the environ then imo we should have 
all apps work like that; this seems prone to errors and confusion.  The 
gnu argument doesn't work on me.  But then again I'm old school...

    Sam