From owner-cvs-all Sat Jan 19 9: 3:29 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 8185137B405; Sat, 19 Jan 2002 09:03:21 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0JH3HD11416; Sat, 19 Jan 2002 20:03:17 +0300 (MSK) (envelope-from ache) Date: Sat, 19 Jan 2002 20:03:16 +0300 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav , mark@grondar.za Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: For all who miss it, PAM changes explanation reposted Message-ID: <20020119170316.GA11315@nagual.pp.ru> References: <200201190901.g0J91H641020@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.24i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jan 19, 2002 at 17:08:55 +0100, Dag-Erling Smorgrav wrote: > *detailed* explanation of what you think is wrong and why you think > your patch is correct. Here it is again modulo exact PAM_CRED_ERR code choosing I not insist on: -------------------------------------------------------------------- More about pam_opie+pam_unix chain, i.e. how it was broken and is fixed: In old variant pam_opie return two states, PAM_SUCCESS and PAM_AUTH_ERR. 1) If we chain it as "sufficient" and get failure, it falls to pam_unix unconditionally, but must do that only when opiefileaccess()+opiealways() permits. This is dangerous from security sense. 2) If we chain it as "required" and get success, we'll get failure in the next pam_unix in the chain due to wrong password. 3) If we chain it as "requsite" and get failure, it stop whole chain unconditionally, but must fallback to pam_unix when opiefileaccess()+opiealways() permits. 4) If we chain it as "optional", ther is no sense to keep it since non-optional pam_unix is already in the chain. All it means that there must be 3-state machine for pam_opie: PAM_SUCCESS, PAM_AUTH_ERR and some 3rd, PAM_CRED_ERR. In that case we can do 1) for PAM_SUCCESS and PAM_AUTH_ERR and disable fallback to pam_unix for PAM_CRED_ERR case. -- Andrey A. Chernov http://ache.pp.ru/ -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message