From owner-freebsd-commit Wed Aug 9 19:09:32 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id TAA10527 for commit-outgoing; Wed, 9 Aug 1995 19:09:32 -0700 Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id TAA10499 for cvs-sys-outgoing; Wed, 9 Aug 1995 19:09:26 -0700 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id TAA10487 ; Wed, 9 Aug 1995 19:09:16 -0700 Received: from corbin.Root.COM (corbin [198.145.90.34]) by Root.COM (8.6.11/8.6.5) with ESMTP id TAA12947; Wed, 9 Aug 1995 19:08:22 -0700 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id TAA00461; Wed, 9 Aug 1995 19:10:02 -0700 Message-Id: <199508100210.TAA00461@corbin.Root.COM> To: esser@ZPR.Uni-Koeln.DE (Stefan Esser) cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_inode.c In-reply-to: Your message of "Wed, 09 Aug 95 14:10:47 +0200." <199508091210.AA09425@Sysiphos> From: David Greenman Reply-To: davidg@Root.COM Date: Wed, 09 Aug 1995 19:09:58 -0700 Sender: commit-owner@FreeBSD.org Precedence: bulk >On Aug 3, 22:49, David Greenman wrote: >} Subject: cvs commit: src/sys/ufs/ffs ffs_inode.c >} davidg 95/08/03 22:49:18 >} >} Modified: sys/ufs/ffs ffs_inode.c >} Log: >} Use the correct flags (IO_SYNC -> B_SYNC) when deciding to do a sync or >} async write in the section that changes the filesize. The bug resulted >} in the updates always being async. > >What performance improvement is >to expect from that patch ? None at all. It isn't a performance change; it's a bugfix. The bug could have resulted in certain types of FS corruption if the system crashed at just the wrong time. >I found that the "-async" option >made no difference at all ! That's because it isn't implemented in the FreeBSD kernel. We will have support for it when we integrate the 4.4BSD-Lite/2 changes. -DG