From owner-freebsd-fs@FreeBSD.ORG Mon Jan 5 15:52:10 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07F94106567C for ; Mon, 5 Jan 2009 15:52:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 9F2B68FC17 for ; Mon, 5 Jan 2009 15:52:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LJrkN-0008YL-CJ; Mon, 05 Jan 2009 17:52:07 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n05Fq33K076409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Jan 2009 17:52:04 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n05Fq3sq002514; Mon, 5 Jan 2009 17:52:03 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n05Fq3AY002513; Mon, 5 Jan 2009 17:52:03 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 5 Jan 2009 17:52:03 +0200 From: Kostik Belousov To: Jaakko Heinonen Message-ID: <20090105155203.GN93900@deviant.kiev.zoral.com.ua> References: <20090103182107.GA4119@a91-153-125-115.elisa-laajakaista.fi> <20090104160043.GI93900@deviant.kiev.zoral.com.ua> <20090105075009.GB7863@a91-153-125-115.elisa-laajakaista.fi> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O27Gs9jTTFWz3gAR" Content-Disposition: inline In-Reply-To: <20090105075009.GB7863@a91-153-125-115.elisa-laajakaista.fi> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LJrkN-0008YL-CJ 6bbd114bd7f9968d987e6ec4d8a793b9 X-Terabit: YES Cc: freebsd-fs@freebsd.org Subject: Re: [patch] ext2fs freeze/corruption on amd64 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2009 15:52:10 -0000 --O27Gs9jTTFWz3gAR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 05, 2009 at 09:50:10AM +0200, Jaakko Heinonen wrote: > On 2009-01-04, Kostik Belousov wrote: > > Please note that find_next_zero_bit() uses gcc extension to perform > > void-pointer arithmetic. Also, at the +2 line, it performs unaligned > > access to the uint32_t entities. >=20 > 76 find_next_zero_bit(void *data, size_t sz, size_t ofs) > 77 { > 78 uint32_t *p; > 79 uint32_t mask; > 80 int bit; > 81=09 > 82 p =3D (uint32_t*)data + (ofs >> 5); >=20 > Hmmm, I don't think so. Did you notice that the type of p is uint32_t * > (line 78) and that data is casted to uint32_t * for pointer arithmetic > (line 82)? You are right, I misparsed that line. --O27Gs9jTTFWz3gAR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkliLKIACgkQC3+MBN1Mb4gBPgCglxiskeDah2zy8lhzDftT70iB SS4Anii+3c4sfCZovsTNXaPpcCpDFv3Z =dYg8 -----END PGP SIGNATURE----- --O27Gs9jTTFWz3gAR--