From owner-svn-ports-head@freebsd.org  Tue Mar 28 14:57:19 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D193DD1F9B2
 for <svn-ports-head@mailman.ysv.freebsd.org>;
 Tue, 28 Mar 2017 14:57:19 +0000 (UTC)
 (envelope-from grembo@freebsd.org)
Received: from mail.grem.de (outcast.grem.de [213.239.217.27])
 by mx1.freebsd.org (Postfix) with SMTP id 44F781E4A
 for <svn-ports-head@freebsd.org>; Tue, 28 Mar 2017 14:57:18 +0000 (UTC)
 (envelope-from grembo@freebsd.org)
Received: (qmail 36750 invoked by uid 89); 28 Mar 2017 14:57:10 -0000
Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@194.97.158.70)
 by mail.grem.de with ESMTPA; 28 Mar 2017 14:57:10 -0000
Date: Tue, 28 Mar 2017 16:57:08 +0200
From: Michael Gmelin <grembo@freebsd.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r437089 - in head/devel: . hhdate hhdate/files
Message-ID: <20170328165708.3feecd6a@bsd64.grem.de>
In-Reply-To: <20170328142701.GA20879@FreeBSD.org>
References: <201703272235.v2RMZKfx024323@repo.freebsd.org>
 <20170328142701.GA20879@FreeBSD.org>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd10.2)
X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}>
 +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl
 LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL
 EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl
 YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq
 AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY
 fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM
 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea
 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+
 xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA
 Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n
 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v
 f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT
 L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF
 CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc
 Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2017 14:57:19 -0000

On Tue, 28 Mar 2017 14:27:01 +0000
Alexey Dokuchaev <danfe@FreeBSD.org> wrote:

> On Mon, Mar 27, 2017 at 10:35:20PM +0000, Michael Gmelin wrote:
> > New Revision: 437089
> > URL: https://svnweb.freebsd.org/changeset/ports/437089
> > 
> > Log:
> >   Add hhdate 2.1.0.35, date and time library based on the C++11 (and
> >   beyond) <chrono> header.
> >   
> > [...]
> > +PORTVERSION=		2.1.0.35
> > +CATEGORIES=		devel
> > +
> > +MAINTAINER=		andreas.sommer87@googlemail.com
> > +COMMENT=		Date and time library based on the C++11
> > (and beyond) <chrono> header +
> > +LICENSE=		MIT
> > +LICENSE_FILE=		${WRKSRC}/LICENSE.txt
> > +
> > +USE_GITHUB=		yes
> > +GH_ACCOUNT=		HowardHinnant
> > +GH_PROJECT=		date
> > +GH_TAGNAME=		3ab6510cab764c1a20926b1e8442af4c9e8a16b2
> > [ and below ]  
> 
> Bogus formatting (one extra tab after knobs), would you please fix it?

These are in to align to

TEST_TEST_TARGET=<tab>test, otherwise it would look like this:

TEST_USES=      compiler:c++11-lib
TEST_TEST_TARGET=test

(replaced tabs by spaces for email)

Would this actually be preferred?

> 
> > +.include <bsd.port.options.mk>
> > +
> > +.if ${PORT_OPTIONS:MTEST}
> > +post-extract:  
> 
> Any reason why option helper target (post-extract-TEST-on) was not
> used here?

Simply unaware it existed, so this would change to:

post-extract-TEST-on:
        ${INSTALL_DATA} ${FILESDIR}/Makefile.in ${WRKSRC}/Makefile
        ${INSTALL_DATA} ${FILESDIR}/test-minimal.cpp ...

correct?

-m

> 
> ./danfe





-- 
Michael Gmelin