Date: Tue, 07 Feb 2017 14:37:15 -0800 From: John Baldwin <jhb@freebsd.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313342 - head/sys/conf Message-ID: <6070632.jUjQOVzxbI@ralph.baldwin.cx> In-Reply-To: <20170207191058.65d72285@zapp> References: <201702061441.v16EfYZx010320@repo.freebsd.org> <2448004.hnTc9TClBV@ralph.baldwin.cx> <20170207191058.65d72285@zapp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, February 07, 2017 07:10:58 PM Andrew Turner wrote: > On Mon, 06 Feb 2017 10:43:09 -0800 > John Baldwin <jhb@freebsd.org> wrote: > > > On Monday, February 06, 2017 02:41:34 PM Andrew Turner wrote: > > > Author: andrew > > > Date: Mon Feb 6 14:41:34 2017 > > > New Revision: 313342 > > > URL: https://svnweb.freebsd.org/changeset/base/313342 > > > > > > Log: > > > Only build the ACPI PCI drivers on x86, they are unlikely to be > > > used on arm64 without dignificant changes. > > > > > > Obtained from: ABT Systems Ltd > > > Sponsored by: The FreeBSD Foundation > > > > I still think this is not really the right approach. Nothing about > > _BBN, _CRS, or _PRT, etc. is x86-specific. > > > > the main issue is the code assumes a single PCIe root controller, e.g. > the pci_cfg* KPI won't work on ThunderX with 6 independent PCIe root > controllers. I expect much of the code could be re-enabled on arm64, > however for now it's easier to disable it. It would be fairly trivial to add a domain argument to the pci_cfg* API. Right now x86 only supports a single domain partly due to this (the MCFG handler doesn't yet handle multiple domains because it can't be handed a request for a domain other than zero, but that is only an implementation choice in part due to this API limitation). I'd be more inclined to pass PCI config requests up to the parent nexus driver and not use pci_cfg* in the ACPI code at all though if that model works better. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6070632.jUjQOVzxbI>