From owner-svn-src-all@freebsd.org Fri Oct 28 17:54:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5969AC2428D; Fri, 28 Oct 2016 17:54:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC46A15E; Fri, 28 Oct 2016 17:54:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u9SHsolI087641 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 28 Oct 2016 20:54:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u9SHsolI087641 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u9SHsoV8087640; Fri, 28 Oct 2016 20:54:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 28 Oct 2016 20:54:50 +0300 From: Konstantin Belousov To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307971 - head/sys/mips/include Message-ID: <20161028175450.GE54029@kib.kiev.ua> References: <201610261737.u9QHb8Ps036831@repo.freebsd.org> <11698910.Akp5I7OyZ5@ralph.baldwin.cx> <20161028153158.GD54029@kib.kiev.ua> <4639059.6gemL8B1hY@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4639059.6gemL8B1hY@ralph.baldwin.cx> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 17:54:56 -0000 On Fri, Oct 28, 2016 at 09:59:26AM -0700, John Baldwin wrote: > Well, we could perhaps patch those to use SA_SIGINFO instead, but if it's > a non-trivial amount of effort I'm not going to bother. I'm surprised that > some of those would use sigcontext. Both mono and go post-date SA_SIGINFO > being standardized and supported on FreeBSD AFAIK. Supporting sigcontext > just means extra BSD-specific code in those applications compared to using > SA_SIGINFO. :-/ For libunwind, I can see a rationale for struct sigcontext use. It seems that on Linux, rt_sigreturn(2) syscall takes struct sigcontext *, and not struct ucontext *, as the argument. This is not unreasonable, because the additional ucontext fields make no sense for sigreturn, for us they are copied into kernel AS but are also unused. So my FreeBSD port followed the existing Linux code. And I started wondering should we change our sigreturn(2) to take sigcontext * instead of ucontext *.