From owner-freebsd-stable@FreeBSD.ORG Tue Apr 23 12:20:11 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 122A38EB; Tue, 23 Apr 2013 12:20:11 +0000 (UTC) (envelope-from prvs=18256b67b3=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) by mx1.freebsd.org (Postfix) with ESMTP id 3E07F1EA2; Tue, 23 Apr 2013 12:20:09 +0000 (UTC) Received: from r2d2 ([46.65.172.4]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50003438737.msg; Tue, 23 Apr 2013 13:20:06 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Tue, 23 Apr 2013 13:20:06 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 46.65.172.4 X-Return-Path: prvs=18256b67b3=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: From: "Steven Hartland" To: "Jeremy Chadwick" References: <20130422051452.GA2148@icarus.home.lan> <51763BF9.2000506@FreeBSD.org> <20130423092602.GA58831@icarus.home.lan> <51765466.4040209@FreeBSD.org> <4D28DBAE46424C268AA22FCDD8657946@multiplay.co.uk> <20130423114722.GA61919@icarus.home.lan> Subject: Re: ada(4) and ahci(4) quirk printing Date: Tue, 23 Apr 2013 13:20:31 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: Kenneth Merry , Alexander Motin , Scott Long , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 12:20:11 -0000 ----- Original Message ----- From: "Jeremy Chadwick" >> Wouldn't camcontrol be a better place for this? > > 1) Not possible at this time -- the ADA_Q_* quirks are not exported to > userland (i.e. /usr/include), only the kernel. camcontrol's source only > relies on things in userland. Thats not an issue which is hard to resolve. > 2) Assuming #1 is addressed: where would it go? You can't put it under > "camcontrol identify" because all (I repeat: ALL) that information comes > from ATA IDENTIFY and thus would be extremely misleading. (Same goes > for SCSI's INQUIRY stuff). Which leads me to... A new quirks option makes the most sence which could be used not only by disks but other areas too. > > 3) I'm never thrilled about adding new commands to camcontrol given > how enormous that thing is to begin with. :-) I also imagine something > like "camcontrol quirks" might lead people to think it lets you adjust > quirks in real-time (nope -- read-only, tunable-only). And that leads > me to... Again depends how its implemented if we fix / improve the CCB situation this could be handled quite elegently with even with the possiblibly of changing on the fly. I know scottl has some thoughts on this. > 4) camcontrol wouldn't address the need/interest for ahci(4) quirks to > be made available. Why? > > All of these things combined do lead me to believe sysctl is the better > place for this. > > P.S. -- I just noticed that our USB layer prints device quirks > regardless of bootverbose -- instead it's based on kernel option > USB_DEBUG, which is enabled in GENERIC. Hooray for inconsistency. Personally while I like a relatively clean output I think its important that the information is available when needed, and that shouldn't require a reboot. So if this info isn't available else where I would say adding to standard output (not verbose only)is a good option especially since its often as important to know a quirk is in place or for 4K not in place as say transfer speed / data spec e.g. SATA 2.x. Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.