From owner-freebsd-current@freebsd.org Wed Feb 7 13:07:37 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07E04F046F6 for ; Wed, 7 Feb 2018 13:07:37 +0000 (UTC) (envelope-from maurizio1018@gmail.com) Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 83A3B685AD; Wed, 7 Feb 2018 13:07:36 +0000 (UTC) (envelope-from maurizio1018@gmail.com) Received: by mail-pf0-x22f.google.com with SMTP id 17so280462pfw.11; Wed, 07 Feb 2018 05:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7Wog/49uS1dO1qS47KyriWg7Xl0WIIH7f2ofillcDak=; b=chIfQSTpVcrX5tO3B8/KCtP5Kv/UMV8qEbfFgJ0nnF3hLKw1jotaf27VDr2Qm9uBRP i4q6Dl4zGXAfaYvzf1xMdzJ7gKmIh8a0mowejdCuFZqUBh0R9qR61ftaIe1RYfS00bmT lQ76fHi3b8eYGuWNWaqnc1nRuj36yk5uTWS3Cp1zmTq/NoMxFTnTcY2/z/6MsX+ikeTs E/JQ9AMd+flVPUgs8tRbpXUTEvaWv46etMd2OzlSNOdDMM7x+3YR1uGwYc1QU5n+zPnU AhvjQmFVt29WSgXSx6WEzIVimTKNHwksYAuVUALEaBrfhaiLEgGO50X+85IarqczbY0V dm4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7Wog/49uS1dO1qS47KyriWg7Xl0WIIH7f2ofillcDak=; b=cuxb01ToQ3Y8cuRzcZjqXt2Vs2hcLSx3NCZZnWyAQDHsSoW2XIl3oEG1IRDXgDWF0z L7r4JAyZhzHQ/uKKFl9Q1td38YAYYdhXG37g91gEdGP+UBz9d0C/uaNB+Uutkr6QAu2T B0irK++kweOoJ0NuMr7mQKRXv4ifBijSNbG9if3eX9Jgt8Mm5CRe/xUaV81RQKwAQnZP TpHJbO8xQ8o2GlPB1FPVLC7bIsvohg3TcP9BipeV3rSi9401+wy0P7VPPpT8y0iwwG/N 8kx00QSWcy+QJWqlFTxOLWsDi2as5HTAZa1qNjhEo8Hc8pr7ebmNtPYcjxe+RVTZkJ7C EzVA== X-Gm-Message-State: APf1xPCfrwq34O+nKv50lPhIaxjMIQLyUqQhxtPTos4hHB5LZwFN9Ifv eFlKlnXjIUNFOMtgpQLrl+fF9habFhjQGIg10zwuvQ== X-Google-Smtp-Source: AH8x224HRFcJ4hrRKOO/tRlslqu2mmfOoQalq1pSzrRd76rBc+zoEg2X703od2kZXag2QLPgrUk1s4ueb02Yudz9wb8= X-Received: by 10.101.74.132 with SMTP id b4mr5044873pgu.355.1518008855563; Wed, 07 Feb 2018 05:07:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.138.144 with HTTP; Wed, 7 Feb 2018 05:07:34 -0800 (PST) In-Reply-To: <1C97132B-099B-4BAA-9C39-A1BE00481CAC@jnielsen.net> References: <3E242843-7D43-4A36-A448-E4B0DACB2AB4@jnielsen.net> <5EDB0747-41DE-4ECF-925E-EF24FAA550F3@jnielsen.net> <1517943001.1366.100.camel@freebsd.org> <1C97132B-099B-4BAA-9C39-A1BE00481CAC@jnielsen.net> From: Maurizio Vairani Date: Wed, 7 Feb 2018 14:07:34 +0100 Message-ID: Subject: Re: Fatal trap 12 booting FreeBSD-CURRENT via isboot kernel module. To: John Nielsen Cc: freebsd-current , Daisuke Aoyama , Ian Lepore Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 13:07:37 -0000 2018-02-06 23:02 GMT+01:00 John Nielsen : > > On Feb 6, 2018, at 11:50 AM, Ian Lepore wrote: > > > > On Tue, 2018-02-06 at 11:33 -0700, John Nielsen wrote: > >> > >> Apparently sending a NULL socket pointer to ifioctl hasn't worked > >> since this commit in 2011: > >> https://svnweb.freebsd.org/base?view=revision&revision=218757 > >> > >> So I'm going to add this patch to the port unconditionally once it > >> works. > >> > >> Unfortunately, I can't compile the port with either my patch below or > >> your original replacement version of isboot_ifup(). :( Did you make > >> other changes? Here's the error I'm getting: > >> > >> --- isboot.o --- > >> isboot.c:425:53: error: incomplete definition of type 'struct thread' > >> error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td); > >> ~~^ > >> /usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct > >> thread' > >> struct thread; > >> ^ > >> 1 error generated. > >> > > > > Try adding #include if it's not already in the list. It > > may be that that file got included via pollution from some other header > > file in the past and maybe now that has changed. > > > > If you're already including sys/proc.h then I'm clueless. > > Thanks Ian, that appears to work. > > Maurizio, can you apply the attached patch to a clean ports tree and see > if isboot-kmod will build and function properly for you? This is all the > changes from this thread and the previous one. If you let me know it works > I'll get the port updated. > > > Hi John, I need some help. I am running: # uname -a FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 04:48:52 UTC 2018 root@releng3.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 after upgrading the ports tree with: # portsnap fetch update I have copied the directory /usr/ports/net/isboot-kmod/ in /root/src/isboot-kmod and /root/src/isboot-kmod.orig # ls -l /root/src total 6 drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod.orig -rw-rw-rw- 1 root wheel 5630 Feb 7 11:38 isboot_patch.txt Trying to apply the patch I obtain the error: # cd /root/src # patch -sC < isboot_patch.txt 2 out of 2 hunks failed while patching isboot-kmod/Makefile 5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c What I am missing ? Thanks again for your work. -- Maurizio