From owner-freebsd-stable@FreeBSD.ORG Wed Jun 27 01:19:07 2012 Return-Path: Delivered-To: Freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2A930106564A; Wed, 27 Jun 2012 01:19:07 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id DC0AF8FC15; Wed, 27 Jun 2012 01:19:06 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.16]) by ltcfislmsgpa07.fnfis.com (8.14.4/8.14.4) with ESMTP id q5R1J539023032 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 26 Jun 2012 20:19:05 -0500 Received: from [10.0.0.101] (10.14.152.61) by smtp.fisglobal.com (10.132.206.16) with Microsoft SMTP Server (TLS) id 14.2.283.3; Tue, 26 Jun 2012 20:19:04 -0500 MIME-Version: 1.0 (Apple Message framework v1257) From: Devin Teske In-Reply-To: Date: Tue, 26 Jun 2012 18:19:02 -0700 Message-ID: <741A1B0E-6C22-4032-9A4A-2181144430ED@fisglobal.com> References: <2322BE6D-24A8-4F4A-84B2-4DFE33BCA65B@fisglobal.com> <4FE3EB9D.9070509@fuzzwad.org> <4FE419CD.60708@rdtc.ru> <4FE4245C.3040806@rdtc.ru> <90361FE2-2298-48E5-B8B6-2BA704781098@fisglobal.com> <4FE431C0.8040509@rdtc.ru> <006001cd5072$84247cd0$8c6d7670$@milos.co.za> To: Clayton Milos X-Mailer: Apple Mail (2.1257) X-Originating-IP: [10.14.152.61] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.7.7855, 1.0.260, 0.0.0000 definitions=2012-06-26_05:2012-06-26, 2012-06-26, 1970-01-01 signatures=0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Devin Teske , Freebsd-stable@freebsd.org Subject: Re: [CFT] Need Testers for: sysutils/bsdconfig X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Devin Teske List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2012 01:19:07 -0000 On Jun 23, 2012, at 12:11 PM, Devin Teske wrote: >=20 > On Jun 22, 2012, at 5:27 AM, Clayton Milos wrote: >=20 [snip] >> Also it said that my user add failed but it was actually added as uid 10= 05. >=20 > I'm working on this one. I'm changing the routines to allow the UNIX pw(8= ) errors to filter through, rather than masking them with a static error on= non-success. >=20 I overhauled the usermgmt module to rely entirely on pw(8). It should work = a lot better now. I addressed all concerns in the rewrite which should be p= ublished soon in the up-coming 0.7.3 PORTVERSION. >=20 >> I added another user and it stated the uid 1005 when I was creating it b= ut >> showed 1006 in the summary screen. It also said that adding the user fai= led. >=20 > "pw usernext" is executed to get the next uid/gid pair that is available.= It's possible a user was added in the process. I've not witnessed this, bu= t will try to replicate. >=20 This race-condition was addressed and should no longer be possible (regardl= ess of whether it was the root cause of the failure to add). >=20 >> Perhaps I used to short a password as there was no password field entere= d in >> /etc/master.passwd >> twat:*:1005:1005::1340540161:1340626570:twat:/home/twat:/bin/sh >> test1:*:1006:1006::1340454020:1340496000:test1:/home/test1:/bin/tcsh >>=20 >=20 > The password is only set (as a separate command) if the pw(8) useradd suc= ceeded. I'm working on catching errors in edge-cases where we should procee= d despite non-success. >=20 This too has been enhanced. >=20 >> When selecting user account expiry the calendar starts at 1 January 1970= . I >> understand that this is when Unix time started but it would be nice for = it >> to start from the current date. >>=20 >=20 > I filed PR docs/169354 against the passwd(5) manual. If nobody picks up t= he PR in a timely fashion, I'll pro-actively modify bsdconfig to follow wha= t the man-page _should_ say versus what it _does_ say about "how to treat t= he value of zero" (the default). PR docs/169354 was closed after being patched by bjk@ (thx again bjk!) The upcoming release folds this change in to coincide with the updated manu= al. --=20 Thanks again for testing! Devin P.S. Keep an eye out for the next revision of this port for more testing. _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.