From owner-svn-src-all@FreeBSD.ORG Thu Jan 19 20:12:28 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55F51106564A; Thu, 19 Jan 2012 20:12:28 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id D15328FC13; Thu, 19 Jan 2012 20:12:27 +0000 (UTC) Received: by yhfs35 with SMTP id s35so246243yhf.13 for ; Thu, 19 Jan 2012 12:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LKBTk17FXUlZKXl9JdCDznOqh+u6zIXsdLOvH/KYbfM=; b=BXGMzHMM6+4UPjuj3ZPQT3cOWoV0SfWstmEEwJuL73w80Th3xUaPIev5KOSKxDZK3/ eENCHl3chQeY9lBsj+ForShkc+39i+1B1zMM8VfX1MKeRQxQ3D9JJkLlo1moJ+KFVeIs KcF1jGqchQkVia/Cc+gycs6E6m6Nb4NzyEF0c= MIME-Version: 1.0 Received: by 10.236.153.42 with SMTP id e30mr42196275yhk.10.1327003947199; Thu, 19 Jan 2012 12:12:27 -0800 (PST) Received: by 10.236.105.210 with HTTP; Thu, 19 Jan 2012 12:12:27 -0800 (PST) In-Reply-To: <20120119191844.GA12760@FreeBSD.org> References: <201201160953.q0G9rPp8026625@svn.freebsd.org> <20120119143837.GA28308@reks> <20120119145132.GZ12760@FreeBSD.org> <20120119164627.GA42205@reks> <20120119191844.GA12760@FreeBSD.org> Date: Thu, 19 Jan 2012 15:12:27 -0500 Message-ID: From: Ben Kaduk To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, Gleb Kurtsou , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r230207 - in head/sys: netinet sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2012 20:12:28 -0000 On 1/19/12, Gleb Smirnoff wrote: > On Thu, Jan 19, 2012 at 06:46:27PM +0200, Gleb Kurtsou wrote: > > G> It's not a big deal for me, I have no problem with replacing them on > G> FreeBSD. FreeBSD is not even officially supported platform for the > G> product and I build/test on FreeBSD solely for the purpose of avoiding > G> linuxisms and platform specific behaviour. Let's hope it won't break for > G> somebody else :) > > I'm pretty sure it will not break anyone, except for people still living > in Internet with classdful addressing. Do you know any? Not directly as classful addressing per se, but the interpretation of an address as possibly-classful is encoded in the voting algorithm for the ubik server elections that make our AFS distributed filesystem work. We support having ubik servers on quite a few different OSes, and we can only change the voting algorithm with an OpenAFS major version number bump because of our interoperability guarantees. I'm not willing to claim that removing classfull addressing will preserve the voting algorithm without an in-depth review that I don't have time to undertake. When you removed ia_net{,mask} from struct in_ifaddr (with no __FreeBSD_version bump! And then merged it to 9.0 during the RC stage!), I had to scramble to keep net/openafs compiling and with the same functionality. It turns out that there is another code path in OpenAFS (used by e.g. Darwin) that instead uses the IN_CLASSA() family of macros, so I could preserve compatibility. But if you go and remove those too, I am screwed. Please don't just assume that no one is using classful addressing and remove things ahead of a reasonable deprecation schedule. -Ben Kaduk