Date: Sun, 30 Mar 2014 23:15:17 -0400 From: Jason Hellenthal <jhellenthal@dataix.net> To: "<dteske@FreeBSD.org>" <dteske@FreeBSD.org> Cc: "<rc@FreeBSD.org>" <rc@FreeBSD.org>, "<dteske@FreeBSD.org>" <dteske@FreeBSD.org> Subject: Re: network.subr _aliasN handling Message-ID: <ECAB4532-F13C-4175-BE9D-E64688D46DDB@dataix.net> In-Reply-To: <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org> References: <11c101cf2f6b$e3aee5d0$ab0cb170$@FreeBSD.org> <20140222.141935.520275210006153242.hrs@allbsd.org> <122101cf2f94$bfd81b30$3f885190$@FreeBSD.org> <20140224.125955.1719844232391066.hrs@allbsd.org> <156001cf33dd$f3b5a330$db20e990$@FreeBSD.org> <04c901cf4c5d$a6a4a030$f3ede090$@FreeBSD.org> <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Agree, it's such a minor change in unnoticed function its worth the risk over the added ease of use. Can't wait to take the local pages out of queue and just let it merge. Looking forward, Thanks again Darren -- Jason Hellenthal Voice: 95.30.17.6/616 JJH48-ARIN > On Mar 30, 2014, at 22:06, <dteske@FreeBSD.org> wrote: > > Never got a go-ahead. What I got was a complaint > that I wasn't normalizing, to which I posted a patch > and never got a response. > > Checking the mailing list archives now… > > http://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.htmlhttp://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.html > > Yeah, conversation kinda ended with that last patch. > > But that wouldn't have deterred me. 30+ days of > silence is equivalent to acceptance -- just that I > had noticed that the patch could be expanded to > include mdconfig{,2} scripts. Was going to wait a > full day to see if anyone balked at the expansion > to include mdconfig{,2} and then move forward. > > Happy to move forward now that it appears that > general opinion is acceptance (and not by silence). > -- > Devin > > From: Jason Hellenthal [mailto:jhellenthal@dataix.net] > Sent: Sunday, March 30, 2014 5:07 PM > To: <dteske@FreeBSD.org> > Cc: Hiroki Sato; <lists@jnielsen.net>; <rc@FreeBSD.org>; <dteske@FreeBSD.org> > Subject: Re: network.subr _aliasN handling > > Has any of this been committed this far? I seem to recall mention of a go-ahead but unsure. > > ? > > -- > Jason Hellenthal > Voice: 95.30.17.6/616 > JJH48-ARIN > > On Mar 30, 2014, at 17:18, <dteske@FreeBSD.org> wrote: > > > > > -----Original Message----- > From: dteske@FreeBSD.org [mailto:dteske@FreeBSD.org] > Sent: Thursday, February 27, 2014 9:04 AM > To: 'Hiroki Sato' > Cc: jhellenthal@dataix.net; lists@jnielsen.net; rc@FreeBSD.org; > dteske@FreeBSD.org > Subject: RE: network.subr _aliasN handling > > -----Original Message----- > From: Hiroki Sato [mailto:hrs@FreeBSD.org] > Sent: Sunday, February 23, 2014 8:00 PM > To: dteske@FreeBSD.org > Cc: jhellenthal@dataix.net; lists@jnielsen.net; rc@FreeBSD.org > Subject: Re: network.subr _aliasN handling > > <dteske@FreeBSD.org> wrote > in <122101cf2f94$bfd81b30$3f885190$@FreeBSD.org>: > > dt> > +list_vars() > dt> > +{ > dt> > + set | { while read LINE; do > dt> > + var="${LINE%%=*}" > dt> > + case "$var" in > dt> > + "$LINE"|*[!a-zA-Z0-9_]*) continue ;; > dt> > + $1) echo $var > dt> > + esac > dt> > + done; } > dt> > +} > dt> > > dt> > This can be inconsistent with normalization of $_if in > dt> > get_if_var() > when > dt> [.-/+] > dt> > is included. > dt> > > dt> [Devin Teske] > dt> > dt> I'm not sure what you mean by "when [.-/+] is included". The line > dt> of > code > > get_if_var() normalizes IF part in the variable name before eval: > > | _if=$1 > | _punct=". - / +" > | for _punct_c in $_punct; do > | _if=`ltr ${_if} ${_punct_c} '_'` > | done > > while list_vars ifconfig_${_if}_alias[0-9]\* does not. > > I think this breaks the following configuration, for example: > > ifconfig_bge0_name="ext.1" > ifconfig_ext_1="inet 192.168.0.1/24" > ifconfig_ext_1_alias0="inet 192.168.1.1/24" > > > Thanks! Didn't know about that feature. I've attached an updated patch for > review which takes this normalization into account > > I was noticing /etc/rc.d/mdconfig and /etc/rc.d/mdconfig2 exhibit the same > behavior, so I've attached a new patch. I didn't find any other instances > where a break in the count would stop the loop prematurely. > > No changes to the old patch, just added mdconfig{,2} to it. > -- > Devin > > _____________ > The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. > <patch.txt> > _____________ > The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. [-- Attachment #2 --] 0 *H 01 0 + 0 *H 90000 *H 01 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0 130518085048Z 140519220947Z0H1 0 U jhellenthal@dataix.net1%0# *H jhellenthal@dataix.net0"0 *H 0 '`TmfkܨJ5u +c'Upb`zv)&ȸXZ*VN6JvLoVoh}g pQDŽKf/tZA˳( "4Ԅ˻'d2h| IBl' ^v^;'e8S99ۿVm|k8_UQtC"5l!kjZ]އQGn \Bh!F TsD%pV^Eӑd¨x"9 г" f 00 U 0 0 U 0 U %0++0 U ڔfmVʢ$䟓0 U #0Sr풜\|~5NԸQ0!U 0jhellenthal@dataix.net0LU C0?0; +70*0.+"http://www.startssl.com/policy.pdf0+00' StartCom Certification Authority0This certificate was issued according to the Class 1 Validation requirements of the StartCom CA policy, reliance only for the intended purpose in compliance of the relying party obligations.06U /0-0+)'%http://crl.startssl.com/crtu1-crl.crl0+009+0-http://ocsp.startssl.com/sub/class1/client/ca0B+06http://aia.startssl.com/certs/sub.class1.client.ca.crt0#U 0http://www.startssl.com/0 *H {0Ӹ,52W{Ey8b [ {7 _+P"n["-,@ŽpJ-W$ݍjWA-6z( RdIZ. KzXє[ K6}{s+v.Qh0PͅK hTw 0I73lz*K v4Kkگ63;p1:ױ@)]ok>:W%XwC1þL/o8~#oP040 0 *H 0}1 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1)0'U StartCom Certification Authority0 071024210155Z 171024210155Z01 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0"0 *H 0 -).2AUGo#G B|NDRpM-B=o -we5JQpa>O.#._<V [~**pz~3WG .ᘟMlr[<Ce6fqO"uxfWN#uicgkv$Lb%y`_{`xK'GN 00U 00U 0 U Sr풜\|~5NԸQ0 U #0N @[i04hCA0f+Z0X0'+0http://ocsp.startssl.com/ca0-+0!http://www.startssl.com/sfsca.crt0[U T0R0'%#!http://www.startssl.com/sfsca.crl0'%#!http://crl.startssl.com/sfsca.crl0U y0w0u +70f0.+"http://www.startssl.com/policy.pdf04+(http://www.startssl.com/intermediate.pdf0 *H }x,\c^ #wMq}>UK/^yX֏y frMIŲB61ymQҨݬZ0& ;@#13qۑ& ̢o 6r_;GO>*I( 74XS1r3)!LJy6Kotˆ# _wSr ;B ADp(fs 䰷6%.W0J3:bC<8t X1<Cn=t==wST~\wkBf|15zUP)(IjVB!OfI=bb\4-*em/нSJm7N[]'@ڽ D9Kr>R7/|o^I@ټ'Pa $ z9a'L)( I}vcH]۸D*W} m>Q|C.(,lQ000 *H 0}1 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1)0'U StartCom Certification Authority0 060917194636Z 360917194636Z0}1 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1)0'U StartCom Certification Authority0"0 *H 0 lF|x{3rb6 "$^wC d̎68#nm<r =3+/AYg} tyL7z9RYFC҅qub4, 4ǖR=3M ;JK&/ r5w<]&6v\t%x- 0-ryF*I cSb:̵fkt+v>mDsb ;ľSV%lQ ʿvmۿ=f VH:KߧXP8u[C lMp[)eݪ]̯1 ҍ{n'f HnB?!>{ pclT\%zɢɋ,~^MXn 2n6IHiMi y"H{ipz7 vOW`g:ԋr"Ɵƶ\R<*s `z/ۣn&0݉W=+ŷv+*r3] KtRK R0N0 U 00 U 0 U N @[i04hCA0dU ]0[0,*(&http://cert.startcom.org/sfsca-crl.crl0+)'%http://crl.startcom.org/sfsca-crl.crl0]U T0P0L +70;0/+#http://cert.startcom.org/policy.pdf05+)http://cert.startcom.org/intermediate.pdf0+00' Start Commercial (StartCom) Ltd.0Limited Liability, read the section *Legal Limitations* of the StartCom Certification Authority Policy available at http://cert.startcom.org/policy.pdf0 `HB 08 `HB +)StartCom Free SSL Certification Authority0 *H lf 4Ѕ^} N8 ^ߦ%K2;=D [I)f% <6+Kh9f=&9 Q{~ZWpi^X ߌE8 ^Wbz )n(DÐ8<CMdE(\s{諱.\dns1:}Q;Mf{<Ӛ ePu/CiyCFrd6% 8w~kjDKx, KD4R' ]xS2݀fuٵh(a.8 gd./pǖ|eCTݥ9`4ɖp, H{ ~k";*RKU"4N&",uJ} d6/# ;sIjWxřCcMw-eriG V$ yX. ~m >J9+u U77Cb VKel$$4"}?eQ 0j r^1o0k001 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0 + 0 *H 1 *H 0 *H 1 140331031518Z0# *H 1ƶ 6d>= knܢ90 +71001 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0 *H 101 0 UIL10U StartCom Ltd.1+0)U "Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0 *H ##n951ٱb[)+1Uetd fMG-vBFB])5B{^NI&*['VY.G[(8,#?]K˵8*1 8-_/* /-:N1 n#Mb\/W/ =[Z"ĎW~Iēw۩ @rTzggUNJfo(N-IJ9%rӱPsŲ^' 9' ڶ#
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ECAB4532-F13C-4175-BE9D-E64688D46DDB>