From owner-freebsd-net@FreeBSD.ORG Sat Jan 8 00:53:00 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9AEF9106566B for ; Sat, 8 Jan 2011 00:53:00 +0000 (UTC) (envelope-from spawk@acm.poly.edu) Received: from acm.poly.edu (acm.poly.edu [128.238.9.200]) by mx1.freebsd.org (Postfix) with ESMTP id 3CD8F8FC1B for ; Sat, 8 Jan 2011 00:52:59 +0000 (UTC) Received: (qmail 9867 invoked from network); 8 Jan 2011 00:26:18 -0000 Received: from unknown (HELO ?192.168.0.2?) (spawk@96.224.221.101) by acm.poly.edu with CAMELLIA256-SHA encrypted SMTP; 8 Jan 2011 00:26:18 -0000 Message-ID: <4D27AF1D.2030505@acm.poly.edu> Date: Fri, 07 Jan 2011 19:26:05 -0500 From: Boris Kochergin User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.12) Gecko/20101031 Thunderbird/3.1.6 MIME-Version: 1.0 To: freebsd-net@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: NDP Ethernet address display X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2011 00:53:00 -0000 Hi. I noticed that ndp(8) doesn't zero-pad Ethernet addresses, which is inconsistent with arp(8): # ndp -an ... 2001:470:897b::1 0:30:48:b1:1b:9c em0 permanent R # arp -an ... ? (128.238.9.201) at 00:30:48:b1:1b:9c on em0 permanent [ethernet] As everything else I can think of zero-pads them, this makes it a little annoying to grep for addresses, etc. Is this intentional? It is the case in 7.x through CURRENT and the fix is quite simple: --- /usr/src/usr.sbin/ndp/ndp.c.orig 2011-01-07 19:16:17.000000000 -0500 +++ /usr/src/usr.sbin/ndp/ndp.c 2011-01-07 19:15:36.000000000 -0500 @@ -828,7 +828,7 @@ if (sdl->sdl_alen) { cp = (u_char *)LLADDR(sdl); - snprintf(hbuf, sizeof(hbuf), "%x:%x:%x:%x:%x:%x", + snprintf(hbuf, sizeof(hbuf), "%02x:%02x:%02x:%02x:%02x:%02x", cp[0], cp[1], cp[2], cp[3], cp[4], cp[5]); } else snprintf(hbuf, sizeof(hbuf), "(incomplete)"); -Boris