From owner-freebsd-fs@FreeBSD.ORG Wed Jun 15 11:59:14 2011 Return-Path: Delivered-To: fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F4D71065747 for ; Wed, 15 Jun 2011 11:59:14 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id CD46B8FC1B for ; Wed, 15 Jun 2011 11:59:13 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 1519A45CA6; Wed, 15 Jun 2011 13:59:11 +0200 (CEST) Received: from localhost (58.wheelsystems.com [83.12.187.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id C8CA245C89; Wed, 15 Jun 2011 13:58:55 +0200 (CEST) Date: Wed, 15 Jun 2011 13:58:53 +0200 From: Pawel Jakub Dawidek To: "Justin T. Gibbs" Message-ID: <20110615115853.GG1975@garage.freebsd.pl> References: <4DF7C406.1080903@scsiguy.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oXNgvKVxGWJ0RPMJ" Content-Disposition: inline In-Reply-To: <4DF7C406.1080903@scsiguy.com> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-3.9 required=4.5 tests=ALL_TRUSTED,BAYES_00, RCVD_IN_SORBS_DUL autolearn=ham version=3.0.4 Cc: fs@FreeBSD.org Subject: Re: [CFR][ZFS] Show removed devices by GUID in zpool output. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2011 11:59:14 -0000 --oXNgvKVxGWJ0RPMJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2011 at 02:26:46PM -0600, Justin T. Gibbs wrote: > The current behavior of zpool_vdev_name() is to report the vdev path > (e.g. /dev/da0) unless > a vdev has the ZPOOL_CONFIG_NOT_PRESENT attribute set. This > attribute is only set when > a vdev is not found during import/mount of a pool. The attached > patch also displays a vdev > by GUID if it cannot be opened post import or is marked removed > (e.g. via a GEOM orphan > event). >=20 > The main motivation for this change is that vdev paths are not > unique to a physical leaf vdev. > It is easy to get into a situation where you need to "detach > /dev/da0" event though da0 is > an active member of the same pool in which a "previous da0" was once > removed. With > zpool_vdev_name() reporting the GUID, the user is equipped to > provide an unambiguous > command that represents their desired action. That's a useful change. It confused users in the past. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --oXNgvKVxGWJ0RPMJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk34nn0ACgkQForvXbEpPzSAqwCgti3FTi2oxoOJPIbVwDQXUSY6 0ywAoI3aBjV9eBJGXQlc7rg8Fo2mij2t =R8cW -----END PGP SIGNATURE----- --oXNgvKVxGWJ0RPMJ--