From owner-cvs-all@FreeBSD.ORG Wed Oct 12 03:37:56 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 05AEA16A41F; Wed, 12 Oct 2005 03:37:56 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C751343D48; Wed, 12 Oct 2005 03:37:55 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9C3bt6W095785; Wed, 12 Oct 2005 03:37:55 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9C3btxf095784; Wed, 12 Oct 2005 03:37:55 GMT (envelope-from csjp) Message-Id: <200510120337.j9C3btxf095784@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Wed, 12 Oct 2005 03:37:55 +0000 (UTC) To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: ports/security/termlog Makefile distinfo X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2005 03:37:56 -0000 csjp 2005-10-12 03:37:55 UTC FreeBSD ports repository (src committer) Modified files: security/termlog Makefile distinfo Log: Fix a couple of problems on 64 bit platforms by importing 2.5: Summary: o Call va_start/va_end for each call to va_arg(). I have no idea why this works on i386 but it shouldn't. This un-busts termlog on 64 bit platforms. o When allocating snp descriptors, allocate the proper size. Currently we are allocating sizeof(struct utmp) when we really should be allocating sizeof(struct snp_d). I can only imagine how this happen, but I am going to guess it was a cut-and-paste-o. This helps un-busts termlog on 64 bit architectures. Fixes Submitted by: Eirik ?verby While we are here: o Open tty line with O_NONBLOCK o Close the line fd after we attach to it as we dont need it. This closes an fd leak. o Remove comment about fd leak Approved by: kris Revision Changes Path 1.12 +1 -1 ports/security/termlog/Makefile 1.9 +2 -2 ports/security/termlog/distinfo