From owner-cvs-all Fri Dec 14 9:49:31 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id A384E37B416; Fri, 14 Dec 2001 09:49:18 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBEHnF316210; Fri, 14 Dec 2001 19:49:15 +0200 (EET) (envelope-from ru) Date: Fri, 14 Dec 2001 19:49:15 +0200 From: Ruslan Ermilov To: Luigi Rizzo Cc: Mark Murray , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011214194915.C13364@sunbay.com> References: <20011214184532.A99179@sunbay.com> <200112141659.fBEGx9U02211@grimreaper.grondar.org> <20011214090706.D49775@iguana.aciri.org> <20011214190949.C7887@sunbay.com> <20011214091511.F49775@iguana.aciri.org> <20011214192127.B99179@sunbay.com> <20011214092358.I49775@iguana.aciri.org> <20011214192759.A13364@sunbay.com> <20011214093840.K49775@iguana.aciri.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011214093840.K49775@iguana.aciri.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Dec 14, 2001 at 09:38:40AM -0800, Luigi Rizzo wrote: > On Fri, Dec 14, 2001 at 07:27:59PM +0200, Ruslan Ermilov wrote: > > On Fri, Dec 14, 2001 at 09:23:58AM -0800, Luigi Rizzo wrote: > > > On Fri, Dec 14, 2001 at 07:21:27PM +0200, Ruslan Ermilov wrote: > > > > > Oh please, how can a perfectly legal (both K&R and ANSI) change in > > > > > the source code ever cause problems ? > > > > > > > > > You misunderstand the point. Host compiler may be buggy. :-) > > > > > > if so it will choke on a thousand similar prototypes in the very > > > same files that I touched. > > > > > OK, I gave you a solution, -DNO_WERROR. :-) > > i do not need this solution, my compiler is not buggy! > Your compiler IS buggy, because it considers not prototyping main() an error. :-) > Anyways, from this discussion I am now convinced that my commit > was correct, so i am not backing it out. > Great. Then please also fix all the 1000... other FreeBSD utilities that don't prototype main(). Why don't you look at the complete discussion on the topic before replying? This was already discussed before, and the decision has been made. (Search for "main AND -Wmissing-prototypes" in the cvs-all ML archive.) Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message