From owner-svn-src-all@freebsd.org Fri Sep 1 17:00:11 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D1A0E1AB34 for ; Fri, 1 Sep 2017 17:00:11 +0000 (UTC) (envelope-from jpaetzel@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E82907F635 for ; Fri, 1 Sep 2017 17:00:10 +0000 (UTC) (envelope-from jpaetzel@FreeBSD.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D8A0421A4E for ; Fri, 1 Sep 2017 13:00:09 -0400 (EDT) Received: from web2 ([10.202.2.212]) by compute2.internal (MEProxy); Fri, 01 Sep 2017 13:00:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1xzxVe Gnsagdtq8da5rpY9JGhi8X4GcmGO34SpZLK10=; b=EE/wBZoNRpdlZlAW9AFWsh Nd+qOlBSWQXtHcOSFwgn1gpJbOJSio3E87KG7Lvj4I/kqKhGZfFGCn8CfIBAvTUI rsbYMddnNyEPb6eE3L2oNB53J4IOsQ7ORPVKR4BxKUKqAX54qQsyMqMipknBI8Ch djbB97aFdxfYPm4A5dbzuuzih49GRddtklXHEhJXHePlX5KAcJbGgbj2UOeIfUkz QWgjjtpNBju9l0Gxy3TiZoRzx5mm9iMBGgpMiEsE5bmzpurIgs++Tl+HF6hapywe 1HfT6vGXQKxCgz/6FunmYrnqnfBjD1wwQk/hwdRkh5m5YJ/sHv1fDZwm3micLqTg == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id A8C716264D; Fri, 1 Sep 2017 13:00:09 -0400 (EDT) Message-Id: <1504285209.3899479.1092460000.413562B8@webmail.messagingengine.com> From: Josh Paetzel To: svn-src-all@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-13b5a8c9 Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf In-Reply-To: <1504284895.41612.29.camel@freebsd.org> Date: Fri, 01 Sep 2017 12:00:09 -0500 References: <201709011554.v81FssRG083114@repo.freebsd.org> <1504284895.41612.29.camel@freebsd.org> X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 17:00:11 -0000 Ok, I'm going to revert it for now. There was a mistake in the commit, the commit message was wrong, and it sounds like we need more consensus. On Fri, Sep 1, 2017, at 11:54 AM, Ian Lepore wrote: > On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote: > > Wait, why?=C2=A0=C2=A0The PR doesn't explain it any better than this co= mmit > > message. > >=20 > > On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel > > wrote: > > >=20 > > > Author: jpaetzel > > > Date: Fri Sep=C2=A0=C2=A01 15:54:53 2017 > > > New Revision: 323087 > > > URL: https://svnweb.freebsd.org/changeset/base/323087 > > >=20 > > > Log: > > > =C2=A0 Take options IPSEC out of GENERIC > > >=20 > > > =C2=A0 PR:=C2=A0=C2=A0=C2=A0220170 > > > =C2=A0 Submitted by: delphij > > > =C2=A0 Reviewed by:=C2=A0=C2=A0ae, glebius > > > =C2=A0 MFC after:=C2=A0=C2=A0=C2=A0=C2=A02 weeks > > > =C2=A0 Differential Revision:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0D11806 >=20 > The differential revision (which should be cited using the complete url > in the commit) seems to indicate that it's because it can be kldloaded. >=20 > This change misses the armv6 platform, where the option appears in > std.armv6, which gets included in GENERIC (and all other armv6 > configs). >=20 > This change seems to warrant an entry in UPDATING, because it's going > to catch a lot of people by surprise. =C2=A0Even people with custom kerne= ls, > if they follow the advice of the handbook and "include GENERIC" then > override things. >=20 > -- Ian > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" --=20 Thanks, Josh Paetzel