From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Feb 3 00:00:20 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59C131065675 for ; Tue, 3 Feb 2009 00:00:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 338A08FC1C for ; Tue, 3 Feb 2009 00:00:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n1300Ili081726 for ; Tue, 3 Feb 2009 00:00:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n1300IQE081718; Tue, 3 Feb 2009 00:00:18 GMT (envelope-from gnats) Resent-Date: Tue, 3 Feb 2009 00:00:18 GMT Resent-Message-Id: <200902030000.n1300IQE081718@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henrik Friedrichsen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73E5F106564A for ; Mon, 2 Feb 2009 23:57:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 46D548FC12 for ; Mon, 2 Feb 2009 23:57:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n12Nv9fV028096 for ; Mon, 2 Feb 2009 23:57:09 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n12Nv98I028095; Mon, 2 Feb 2009 23:57:09 GMT (envelope-from nobody) Message-Id: <200902022357.n12Nv98I028095@www.freebsd.org> Date: Mon, 2 Feb 2009 23:57:09 GMT From: Henrik Friedrichsen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/131322: [PATCH] audio/faad: install mp4ff library so that mpd plays mp4 files X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2009 00:00:21 -0000 >Number: 131322 >Category: ports >Synopsis: [PATCH] audio/faad: install mp4ff library so that mpd plays mp4 files >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Feb 03 00:00:17 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Henrik Friedrichsen >Release: 7.1-STABLE >Organization: >Environment: FreeBSD kiwi.icecap 7.1-STABLE FreeBSD 7.1-STABLE #0: Thu Jan 29 23:20:34 CET 2009 root@kiwi.icecap:/usr/obj/usr/src/sys/PLUTONIUM i386 >Description: Per the latest faad2 sources from audiocoding.com, that project's maintainer has changed faad2 so that it does not build or ship a separate mp4ff library, however that library is now required by mpd to play MP4 files. This patch will enable the build of a mp4ff library and will install it with it's headers. Along with [1] this will fix the playback of mp4 files, otherwise mp4 playback is BROKEN in audio/musicpd. For a further reference, see: http://musicpd.org/mantis/view.php?id=1817 [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131204 >How-To-Repeat: >Fix: Apply patch. Patch attached with submission follows: diff -Naur ./Makefile ../faad/Makefile --- ./Makefile 2009-02-03 00:24:46.000000000 +0100 +++ ../faad/Makefile 2009-02-03 00:48:50.000000000 +0100 @@ -7,7 +7,7 @@ PORTNAME= faad2 PORTVERSION= 2.6.1 -PORTREVISION= 1 +PORTREVISION= 2 PORTEPOCH= 1 CATEGORIES= audio MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} @@ -40,4 +40,8 @@ @${ECHO_CMD} "SUBDIRS = libfaad common frontend" > \ ${WRKSRC}/Makefile.am +post-install: + ${INSTALL_DATA} ${WRKSRC}/common/mp4ff/mp4ff.h ${PREFIX}/include/mp4ff.h + ${INSTALL_DATA} ${WRKSRC}/common/mp4ff/mp4ff_int_types.h ${PREFIX}/include/mp4ff_int_types.h + .include diff -Naur ./files/patch-Makefile.am ../faad/files/patch-Makefile.am --- ./files/patch-Makefile.am 1970-01-01 01:00:00.000000000 +0100 +++ ../faad/files/patch-Makefile.am 2008-11-16 04:11:26.000000000 +0100 @@ -0,0 +1,13 @@ +Index: common/mp4ff/Makefile.am +=================================================================== +RCS file: /cvsroot/faac/faad2/common/mp4ff/Makefile.am,v +retrieving revision 1.9 +diff -u -r1.9 Makefile.am +--- common/mp4ff/Makefile.am 7 May 2006 18:09:00 -0000 1.9 ++++ common/mp4ff/Makefile.am 16 Nov 2008 02:09:26 -0000 +@@ -1,4 +1,4 @@ +-noinst_LTLIBRARIES = libmp4ff.la ++lib_LTLIBRARIES = libmp4ff.la + + libmp4ff_la_CFLAGS = -DUSE_TAGGING=1 + diff -Naur ./pkg-plist ../faad/pkg-plist --- ./pkg-plist 2009-02-03 00:24:46.000000000 +0100 +++ ../faad/pkg-plist 2009-02-03 00:44:41.000000000 +0100 @@ -1,7 +1,13 @@ bin/faad include/faad.h include/neaacdec.h +include/mp4ff.h +include/mp4ff_int_types.h lib/libfaad.a lib/libfaad.la lib/libfaad.so lib/libfaad.so.0 +lib/libmp4ff.a +lib/libmp4ff.la +lib/libmp4ff.so +lib/libmp4ff.so.0 >Release-Note: >Audit-Trail: >Unformatted: