Date: Sun, 3 Nov 2013 19:13:53 -0600 From: Scot Hetzel <swhetzel@gmail.com> To: Kimmo Paasiala <kpaasial@gmail.com>, freebsd-ports <freebsd-ports@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org> Subject: Re: Staging DOs & DON'Ts Message-ID: <CACdU%2Bf8uTuMGkdwQtzDddkrdwWCg=PgtLZ68Jj=e79PMYO34RA@mail.gmail.com> In-Reply-To: <20131031153710.GA5610@straylight.m.ringlet.net> References: <CA%2B7WWSfVYOudaobwe39aYYXt5y0MxJRomD3bE--cUPK%2BCukUqw@mail.gmail.com> <20131031153710.GA5610@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 31, 2013 at 10:37 AM, Peter Pentchev <roam@ringlet.net> wrote:
> On Thu, Oct 31, 2013 at 10:30:03AM +0200, Kimmo Paasiala wrote:
>> Could we have this as an example what not to in the Makefile. It is
>> from the latest change to the Makefile of sysutils/kiconvtool.
>>
>>
>> MAKE_ARGS= PREFIX="${STAGEDIR}${PREFIX}"
>>
>> This breaks stuff that edits scripts in place trying to replace paths
>> that depend on the value of PREFIX.
>
> The proper way to do this - and the way it's done on other OSs and other
> packaging systems that have the staging directory feature - is to:
>
> 1. Pass ${STAGEDIR} as a separate build option to the actual build;
> it's traditional to pass it as the DESTDIR option:
>
> MAKE_ARGS+= DESTDIR="${STAGEDIR}"
>
There is no need add this to the ports Makefile, as stage already does
this for you in bsd.stage.mk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACdU%2Bf8uTuMGkdwQtzDddkrdwWCg=PgtLZ68Jj=e79PMYO34RA>