From owner-freebsd-stable@FreeBSD.ORG Wed Apr 28 15:41:19 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2A4D10656F6; Wed, 28 Apr 2010 15:41:19 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 24EA58FC1E; Wed, 28 Apr 2010 15:41:18 +0000 (UTC) Received: by fxm15 with SMTP id 15so570521fxm.13 for ; Wed, 28 Apr 2010 08:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=lOrbkUzseRSJyT928rwoe9Lov9H7LnfONEZZHVvjfYQ=; b=pdKkSf+ONJDBGJ85kQb3wwrLFW8TsD4i2VHBGDMq++dphVckG+4b06Xg3uvss/sXrJ fAVyMXmEDG3vcU9gww0driwk668j9NOCYwpA9O7RDJyceamVstqubYrpV9R2VS8eoMmr GMyKRhoUKZL6gzXoVTzGx/JK2KQA3V4hKZzbo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=A0gjH5GU9Cl/1orFzCUCajCwLOCNe+tntxu05Fer4BNM7UJRc9BNQPLFYH9LPwbBph wabcdpqlegusbTzvQ1COOrBAb6LvRffrWQD9lQq5Ryd5Ag+SEaRk87wwIR6OqLDnvL2i Dg5zLZAeHI9aDYJuB1sBLQ387NBDpeiayD/BQ= MIME-Version: 1.0 Received: by 10.223.127.196 with SMTP id h4mr399243fas.56.1272469268784; Wed, 28 Apr 2010 08:41:08 -0700 (PDT) Received: by 10.223.121.195 with HTTP; Wed, 28 Apr 2010 08:41:08 -0700 (PDT) In-Reply-To: <20100428160428.R4522@ns1.as.pvp.se> References: <20100427150736.A4522@ns1.as.pvp.se> <201004271721.34248.jhb@freebsd.org> <20100428091758.F4522@ns1.as.pvp.se> <201004280802.26267.jhb@freebsd.org> <20100428160428.R4522@ns1.as.pvp.se> Date: Wed, 28 Apr 2010 17:41:08 +0200 Message-ID: From: Giovanni Trematerra To: kama Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-stable@freebsd.org, John Baldwin Subject: Re: HP 380 G4 - ciss kernel page fault. X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2010 15:41:19 -0000 On Wed, Apr 28, 2010 at 4:07 PM, kama wrote: > > > On Wed, 28 Apr 2010, John Baldwin wrote: > >> On Wednesday 28 April 2010 3:22:44 am kama wrote: >> > >> > On Tue, 27 Apr 2010, John Baldwin wrote: >> > >> > > On Tuesday 27 April 2010 9:30:12 am kama wrote: >> > > > >> > > > Hi. >> > > > >> > > > I have problem when probing the ciss device. Causing a kernel pani= c. >> This >> > > > happened when I upgraded from 6.3 to 7.3-stable. Booting the old k= ernel >> > > > works. So something has changed. I am also getting the error on bo= th the >> > > > 7.3 and the 8.0 install cd's. >> > > > >> > > > The ciss that causing the problem is a Smart Array 6404 and its th= e >> addon >> > > > card that it faults at. The server disconnect it due to an error. = But >> > > > since it works on 6.3 it is something that have changed. FreeBSD s= hould >> > > > not panic, it should just disable it. >> > > > >> > > > Also I tried to disable the card in the BIOS, but FreeBSD try to p= robe >> it >> > > > anyway and panic. >> > > > >> > > > This whats comes up on a verbose boot through the ILO remote conso= le. >> > > > (typed in manually from a screenshot) >> > > > >> > > > ciss2: port 0x6400-0x64ff mem >> > > > 0xfdf70000-0xfdf71fff irq 98 at device 5.0 on pcill >> > > > ciss2: Reserved 0x2000 bytes for rid 0x10 type 3 at 0xfdf70000 >> > > > pci11: child ciss2 requested type 3 for rid 0, but the BAR says it= is an >> > > > ioport >> > > > ciss2: can't allocate config window >> > > > kernel trap 12 with interupts disabled >> > > >> > > Can you get the ciss2 boot messages from a working 6.x kernel? >> > >> > This is the verbose boot on 6.3. >> > >> > FreeBSD 6.3-STABLE #3: Thu Mar =A06 14:29:33 CET 2008 >> > >> > ciss1: 10 physical devices >> > ciss1: 4 logical drives >> > ciss1: logical drive (b0t0): RAID 1, 69120MB online >> > ciss1: logical drive (b0t1): RAID 1, 69120MB online >> > ciss1: logical drive (b0t2): RAID 1, 139776MB online >> > ciss1: logical drive (b0t3): RAID 1, 139776MB online >> > >> > ciss2: port 0x6400-0x64ff mem >> > 0xfdf70000-0xfdf71fff,0xfdf00000-0xfdf3ffff irq 98 at device 5.0 on pc= i11 >> > ciss2: Reserved 0x2000 bytes for rid 0x10 type 3 at 0xfdf70000 >> > pci11: child ciss2 requested type 3 for rid 0, but the BAR says it is = an >> > ioport >> > ciss2: can't allocate config window >> > device_attach: ciss2 attach returned 6 >> >> Oh, so it didn't work in 6.x either, it just handles failure less gracef= ully >> in 7.0+? > > No, ciss2 is disabled. The difference is that 6.x continue to boot instea= d > of a kernel panic as in 7.x and 8.x. > > I dont have any disks attached to ciss2, so I dont really need it. But > ciss1 and ciss2 is on the same physical card, so I cant just remove it. > Could you try this one if you are looking for a patch to 7-STABLE. Thank you diff -r ffd3e5d37758 sys/dev/ciss/ciss.c --- a/sys/dev/ciss/ciss.c Wed Apr 28 10:20:41 2010 -0400 +++ b/sys/dev/ciss/ciss.c Wed Apr 28 11:39:05 2010 -0400 @@ -394,6 +394,8 @@ ciss_attach(device_t dev) sc =3D device_get_softc(dev); sc->ciss_dev =3D dev; + mtx_init(&sc->ciss_mtx, "cissmtx", NULL, MTX_DEF); + callout_init_mtx(&sc->ciss_periodic, &sc->ciss_mtx, 0); /* * Work out adapter type. @@ -428,8 +430,6 @@ ciss_attach(device_t dev) ciss_initq_busy(sc); ciss_initq_complete(sc); ciss_initq_notify(sc); - mtx_init(&sc->ciss_mtx, "cissmtx", NULL, MTX_DEF); - callout_init_mtx(&sc->ciss_periodic, &sc->ciss_mtx, 0); /* * Initalize device sysctls. @@ -494,8 +494,11 @@ ciss_attach(device_t dev) error =3D 0; out: - if (error !=3D 0) - ciss_free(sc); + if (error !=3D 0) { + /* ciss_free() expects the mutex to be held */ + mtx_lock(&sc->ciss_mtx); + ciss_free(sc); + } return(error); } -- Gianni